Skip to content

perf: dedupe TestDataFormatter.FormatArguments with pooled StringBuilder #6088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 1 commit into from
May 28, 2026
Merged

perf: dedupe TestDataFormatter.FormatArguments with pooled StringBuilder #6088

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 16 additions & 17 deletions TUnit.Core/DataSources/TestDataFormatter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,31 +26,30 @@ public static string FormatArguments(object?[] arguments, List<Func<object?, str
return string.Empty;
}

var formattedArgs = new string[arguments.Length];
for (var i = 0; i < arguments.Length; i++)
var builder = StringBuilderPool.Get();
try
{
formattedArgs[i] = ArgumentFormatter.Format(arguments[i], formatters);
for (var i = 0; i < arguments.Length; i++)
{
if (i > 0)
{
builder.Append(", ");
}
builder.Append(ArgumentFormatter.Format(arguments[i], formatters));
}
return builder.ToString();
}
finally
{
StringBuilderPool.Return(builder);
}
return string.Join(", ", formattedArgs);
}

/// <summary>
/// Formats an array of arguments using default formatting
/// </summary>
public static string FormatArguments(object?[] arguments)
{
if (arguments.Length == 0)
{
return string.Empty;
}

var formattedArgs = new string[arguments.Length];
for (var i = 0; i < arguments.Length; i++)
{
formattedArgs[i] = ArgumentFormatter.Format(arguments[i], []);
}
return string.Join(", ", formattedArgs);
}
=> FormatArguments(arguments, []);

/// <summary>
/// Creates a display name from test metadata and arguments
Expand Down
Loading