Skip to content
Merged
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 36 additions & 10 deletions TUnit.Core/Helpers/ArgumentFormatter.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System.Collections;
using System.Text;

namespace TUnit.Core.Helpers;

Expand Down Expand Up @@ -44,21 +45,34 @@ public static string FormatArguments(IEnumerable<object?> arguments)
if (list.Count == 0)
return string.Empty;

var formatted = new string[list.Count];
if (list.Count == 1)
return FormatDefault(list[0]);

// ~16 chars per formatted arg avoids the internal buffer resizing for typical counts.
var builder = new StringBuilder(list.Count * 16);
for (int i = 0; i < list.Count; i++)
{
formatted[i] = FormatDefault(list[i]);
if (i > 0)
{
builder.Append(", ");
}
builder.Append(FormatDefault(list[i]));
}
return string.Join(", ", formatted);
return builder.ToString();
}

var elements = new List<string>();
// Non-IList fallback (rare: callers normally pass object?[]). Build directly into a
// StringBuilder rather than allocating an intermediate List<string> + string.Join.
var fallbackBuilder = new StringBuilder();
foreach (var arg in arguments)
{
elements.Add(FormatDefault(arg));
if (fallbackBuilder.Length > 0)
{
fallbackBuilder.Append(", ");
}
fallbackBuilder.Append(FormatDefault(arg));
}

return elements.Count == 0 ? string.Empty : string.Join(", ", elements);
return fallbackBuilder.ToString();
}

private static string FormatDefault(object? o)
Expand Down Expand Up @@ -140,12 +154,24 @@ private static string FormatDefault(object? o, Type? parameterType)
private static string FormatTuple(object tuple)
{
var elements = TupleHelper.UnwrapTuple(tuple);
var formatted = new string[elements.Length];

if (elements.Length == 0)
return "()";

if (elements.Length == 1)
return $"({FormatDefault(elements[0])})";

var builder = new StringBuilder("(");
for (int i = 0; i < elements.Length; i++)
{
formatted[i] = FormatDefault(elements[i]);
if (i > 0)
{
builder.Append(", ");
}
builder.Append(FormatDefault(elements[i]));
}
return $"({string.Join(", ", formatted)})";
builder.Append(')');
return builder.ToString();
}

private static string FormatEnumerable(IEnumerable enumerable)
Expand Down
Loading