Skip to content

perf(core): avoid string[] alloc in ArgumentFormatter.FormatArguments #6080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 4 commits into from
May 28, 2026
+37 −10
Merged

perf(core): avoid string[] alloc in ArgumentFormatter.FormatArguments #6080

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
39c1d81
perf(core): avoid string[] alloc in ArgumentFormatter.FormatArguments
thomhurst May 28, 2026
2d86c18
perf: apply StringBuilder path to non-IList fallback and FormatTuple
thomhurst May 28, 2026
7d6d404
perf(core): pre-size StringBuilder in ArgumentFormatter multi-arg path
thomhurst May 28, 2026
43ffa7f
perf(core): pre-size FormatTuple StringBuilder; trim fallback comment
thomhurst May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions TUnit.Core/Helpers/ArgumentFormatter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System.Collections;
using System.Text;

namespace TUnit.Core.Helpers;

Expand Down Expand Up @@ -44,12 +45,19 @@ public static string FormatArguments(IEnumerable<object?> arguments)
if (list.Count == 0)
return string.Empty;

var formatted = new string[list.Count];
if (list.Count == 1)
return FormatDefault(list[0]);

var builder = new StringBuilder();
for (int i = 0; i < list.Count; i++)
{
formatted[i] = FormatDefault(list[i]);
if (i > 0)
{
builder.Append(", ");
}
builder.Append(FormatDefault(list[i]));
}
return string.Join(", ", formatted);
return builder.ToString();
}

var elements = new List<string>();
Expand Down
Loading