Skip to content

perf(core): replace OfType().FirstOrDefault()/.Any() with foreach in ClassConstructorHelper #6078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 1 commit into from
May 28, 2026
Merged

perf(core): replace OfType().FirstOrDefault()/.Any() with foreach in ClassConstructorHelper #6078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions TUnit.Core/Helpers/ClassConstructorHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static class ClassConstructorHelper
return await TryCreateInstanceWithClassConstructor(
attributes,
testClassType,
TestBuilderContext.FromTestContext(testContext, attributes.OfType<IDataSourceAttribute>().FirstOrDefault()),
TestBuilderContext.FromTestContext(testContext, GetDataSourceAttribute(attributes)),
testSessionId);
}

Expand Down Expand Up @@ -70,7 +70,28 @@ public static class ClassConstructorHelper
/// </summary>
public static bool HasClassConstructorAttribute(Attribute[] attributes)
{
return attributes.OfType<ClassConstructorAttribute>().Any();
foreach (Attribute attribute in attributes)
{
if (attribute is ClassConstructorAttribute)
{
return true;
}
}

return false;
}

private static IDataSourceAttribute? GetDataSourceAttribute(IReadOnlyList<Attribute> attributes)
{
foreach (Attribute attribute in attributes)
{
if (attribute is IDataSourceAttribute dataSourceAttribute)
{
return dataSourceAttribute;
}
}

return null;
}

/// <summary>
Expand Down
Loading