Skip to content

perf: avoid Cast<object>().FirstOrDefault() iterator alloc in CastHelper (#6029) #6074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 2 commits into from
May 28, 2026
Merged

perf: avoid Cast<object>().FirstOrDefault() iterator alloc in CastHelper (#6029) #6074

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2d4b24
perf: avoid Cast<object>().FirstOrDefault() iterator alloc in CastHel…
thomhurst May 28, 2026
1116d08
refactor: rename loop var e to item in CastHelper
thomhurst May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion TUnit.Core/Helpers/CastHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,12 @@ private static bool TryAotSafeConversion(Type targetType, Type sourceType, objec
// Unwrap single-element enumerables (but not strings or arrays)
if (value is not string && !sourceType.IsArray && value is IEnumerable enumerable && !typeof(IEnumerable).IsAssignableFrom(targetType))
{
var firstElement = enumerable.Cast<object>().FirstOrDefault();
object? firstElement = null;
foreach (var item in enumerable)
{
firstElement = item;
break;
}
if (firstElement != null)
{
// Recursively try to cast the first element
Expand Down
Loading