Skip to content

perf: replace LINQ Any with foreach in TestGenericTypeResolver (#6044) #6072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 2 commits into from
May 28, 2026
+27 −2
Merged

perf: replace LINQ Any with foreach in TestGenericTypeResolver (#6044) #6072

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82b62b0
perf: replace LINQ Any with foreach in TestGenericTypeResolver (#6044)
thomhurst May 28, 2026
6b2c7a7
perf: also drop LINQ All in TestGenericTypeResolver fallback
thomhurst May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion TUnit.Engine/Services/TestGenericTypeResolver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,19 @@ private static Type[] ResolveMethodGenericArguments(
{
// Handle the case where some parameter types are Object (placeholders for generic parameters)
// This happens when data sources provide untyped data or when we have mixed generic/non-generic parameters
if (parameterTypes.Any(t => t == typeof(object)) && methodArguments.Length > 0)
var hasObjectParameter = false;
if (methodArguments.Length > 0)
{
foreach (var parameterType in parameterTypes)
{
if (parameterType == typeof(object))
{
hasObjectParameter = true;
break;
}
}
}
if (hasObjectParameter)
{
// Check if this is a simple generic method with one type parameter and mixed parameters
if (genericMethodInfo.ParameterNames.Length == 1 && parameterTypes.Length >= 1)
Expand Down
Loading