Skip to content

perf: use TryAdd in TestDependencyResolver dependency dedupe #6068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 2 commits into from
May 28, 2026
Merged

perf: use TryAdd in TestDependencyResolver dependency dedupe #6068

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
216d42f
perf: use TryAdd in TestDependencyResolver dependency dedupe (#6042)
thomhurst May 28, 2026
57dc8bc
perf: also apply TryAdd in ResolveDependenciesForTestLockFree
thomhurst May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions TUnit.Engine/Services/TestDependencyResolver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,7 @@ private bool ResolveDependenciesForTest(AbstractExecutableTest test)
continue;
}

if (!uniqueDependencies.ContainsKey(dep.Test))
{
uniqueDependencies[dep.Test] = dep;
}
uniqueDependencies.TryAdd(dep.Test, dep);
}

test.Dependencies = uniqueDependencies.Values.ToArray();
Expand Down
Loading