Skip to content

perf: replace OrderBy().ToArray() with Array.Sort in ConstraintKeyScheduler #6067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 1 commit into from
May 28, 2026
Merged

perf: replace OrderBy().ToArray() with Array.Sort in ConstraintKeyScheduler #6067

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions TUnit.Engine/Scheduling/ConstraintKeyScheduler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,18 @@ public async ValueTask ExecuteTestsWithConstraintsAsync(
return;
}

// Sort tests by priority
var sortedTests = tests.OrderBy(static t => t.Priority).ToArray();
// Sort tests by priority. Defensive copy so we don't mutate the caller's array.
// Pack (Priority, OriginalIndex) into a long key to preserve OrderBy's stability
// (Array.Sort itself is not stable) while using the fast default Int64 comparer.
// Replaces `tests.OrderBy(...).ToArray()` which allocates iterator + buffer + array.
var sortedTests = new (AbstractExecutableTest Test, IReadOnlyList<string> ConstraintKeys, int Priority)[tests.Length];
var sortKeys = new long[tests.Length];
for (var i = 0; i < tests.Length; i++)
{
sortedTests[i] = tests[i];
sortKeys[i] = ((long)tests[i].Priority << 32) | (uint)i;
}
Array.Sort(sortKeys, sortedTests);

// Track which constraint keys are currently in use
var lockedKeys = new HashSet<string>();
Expand Down
Loading