Skip to content

fix(tests): refresh net472 PublicAPI snapshot, bump CloudShop fulfilment timeout#5761

Merged
thomhurst merged 1 commit intomainfrom
fix/post-5740-snapshot-and-timeout
Apr 26, 2026
Merged

fix(tests): refresh net472 PublicAPI snapshot, bump CloudShop fulfilment timeout#5761
thomhurst merged 1 commit intomainfrom
fix/post-5740-snapshot-and-timeout

Conversation

@thomhurst
Copy link
Copy Markdown
Owner

Summary

Cleans up two CI failures inherited from #5740's merge (which was admin-merged with red checks):

  • net472 PublicAPI snapshot stale: [Feature]: IsEqualTo() & co with implicitly convertible wrappers #5720 / feat(assertions): IsEqualTo with implicitly-convertible wrappers (#5720) #5751 added new IsEqualTo<TValue, TOther> overloads carrying [OverloadResolutionPriority(-1)] and [RequiresUnreferencedCode]. Those attributes don't exist on netstandard2.0, so the generated public API for net472 doesn't render them — but the verified snapshot still includes the six attribute lines. Drop them so net472 matches reality.
  • CloudShop Step3_Worker_Fulfills_Order: ubuntu-latest hit the 120s WaitsFor timeout (test ran 119719ms). RabbitMQ + Worker pipeline under concurrent load needs more headroom; bump to 180s. Behavioral guard is still "must observe Fulfilled state at all", not "must do so in <120s".

Test plan

  • dotnet run -c Release -f net472 in TUnit.PublicAPI — 3/3 passed locally on Windows
  • CI: ubuntu/macos/windows modular pipeline green
  • CI: CloudShop integration tests green

…ilment timeout

Rebased onto main brings in #5720/#5751 IsEqualTo wrapper overloads. On
netstandard2.0 the [OverloadResolutionPriority] and [RequiresUnreferencedCode]
attributes don't render, so the Net4_7 verified snapshot loses six lines.

Step3_Worker_Fulfills_Order timed out after the previous 120s bump on the
ubuntu-latest runner; widen to 180s to absorb RabbitMQ + Worker delivery
under concurrent load.
Copy link
Copy Markdown
Contributor

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This is a clean, minimal CI-fix PR addressing two regressions introduced by the admin-merge of #5740.

The removal of the six attribute lines is correct. [RequiresUnreferencedCode] and [OverloadResolutionPriority(-1)] are not available on netstandard2.0/net472, so their presence in the snapshot was a false-positive introduced when the overloads were added in #5720/#5751. Dropping them brings the snapshot back in sync with reality.

examples/CloudShop/CloudShop.Tests/Tests/Orders/OrderWorkflowTests.cs

The 120s → 180s bump is reasonable given the reported run time of ~119.7s (99.8% of the old limit). One minor observation worth keeping in mind: bumping timeouts can sometimes mask a growing latency trend. If this test edges toward 180s in future CI runs, it may be worth profiling the RabbitMQ + Worker startup/warmup path rather than bumping again — but that investigation is out of scope here and the 50% headroom added is a sensible buffer for concurrent-load CI environments.

Overall

Both fixes are accurate, minimal, and well-scoped. No issues found. ✅

Copy link
Copy Markdown
Contributor

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This is a clean, minimal CI-fix PR addressing two regressions introduced by the admin-merge of #5740.

net472 PublicAPI snapshot

The removal of the six attribute lines is correct. [RequiresUnreferencedCode] and [OverloadResolutionPriority(-1)] are not available on netstandard2.0/net472, so their presence in the snapshot was a false-positive introduced when the overloads were added in #5720/#5751. Dropping them brings the snapshot back in sync with reality.

CloudShop Step3_Worker_Fulfills_Order timeout

The 120s to 180s bump is reasonable given the reported run time of ~119.7s (99.8% of the old limit). One minor observation worth keeping in mind: bumping timeouts can sometimes mask a growing latency trend. If this test edges toward 180s in future CI runs, it may be worth profiling the RabbitMQ + Worker startup/warmup path rather than bumping again — but that investigation is out of scope here and the 50% headroom is a sensible buffer for concurrent-load CI environments.

Overall

Both fixes are accurate, minimal, and well-scoped. No issues found.

@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@thomhurst thomhurst merged commit a919a25 into main Apr 26, 2026
15 of 16 checks passed
@thomhurst thomhurst deleted the fix/post-5740-snapshot-and-timeout branch April 26, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant