Conversation
…ilment timeout Rebased onto main brings in #5720/#5751 IsEqualTo wrapper overloads. On netstandard2.0 the [OverloadResolutionPriority] and [RequiresUnreferencedCode] attributes don't render, so the Net4_7 verified snapshot loses six lines. Step3_Worker_Fulfills_Order timed out after the previous 120s bump on the ubuntu-latest runner; widen to 180s to absorb RabbitMQ + Worker delivery under concurrent load.
There was a problem hiding this comment.
Code Review
This is a clean, minimal CI-fix PR addressing two regressions introduced by the admin-merge of #5740.
The removal of the six attribute lines is correct. [RequiresUnreferencedCode] and [OverloadResolutionPriority(-1)] are not available on netstandard2.0/net472, so their presence in the snapshot was a false-positive introduced when the overloads were added in #5720/#5751. Dropping them brings the snapshot back in sync with reality.
examples/CloudShop/CloudShop.Tests/Tests/Orders/OrderWorkflowTests.cs
The 120s → 180s bump is reasonable given the reported run time of ~119.7s (99.8% of the old limit). One minor observation worth keeping in mind: bumping timeouts can sometimes mask a growing latency trend. If this test edges toward 180s in future CI runs, it may be worth profiling the RabbitMQ + Worker startup/warmup path rather than bumping again — but that investigation is out of scope here and the 50% headroom added is a sensible buffer for concurrent-load CI environments.
Overall
Both fixes are accurate, minimal, and well-scoped. No issues found. ✅
There was a problem hiding this comment.
Code Review
This is a clean, minimal CI-fix PR addressing two regressions introduced by the admin-merge of #5740.
net472 PublicAPI snapshot
The removal of the six attribute lines is correct. [RequiresUnreferencedCode] and [OverloadResolutionPriority(-1)] are not available on netstandard2.0/net472, so their presence in the snapshot was a false-positive introduced when the overloads were added in #5720/#5751. Dropping them brings the snapshot back in sync with reality.
CloudShop Step3_Worker_Fulfills_Order timeout
The 120s to 180s bump is reasonable given the reported run time of ~119.7s (99.8% of the old limit). One minor observation worth keeping in mind: bumping timeouts can sometimes mask a growing latency trend. If this test edges toward 180s in future CI runs, it may be worth profiling the RabbitMQ + Worker startup/warmup path rather than bumping again — but that investigation is out of scope here and the 50% headroom is a sensible buffer for concurrent-load CI environments.
Overall
Both fixes are accurate, minimal, and well-scoped. No issues found.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Summary
Cleans up two CI failures inherited from #5740's merge (which was admin-merged with red checks):
IsEqualTo<TValue, TOther>overloads carrying[OverloadResolutionPriority(-1)]and[RequiresUnreferencedCode]. Those attributes don't exist on netstandard2.0, so the generated public API for net472 doesn't render them — but the verified snapshot still includes the six attribute lines. Drop them so net472 matches reality.Step3_Worker_Fulfills_Order: ubuntu-latest hit the 120s WaitsFor timeout (test ran 119719ms). RabbitMQ + Worker pipeline under concurrent load needs more headroom; bump to 180s. Behavioral guard is still "must observe Fulfilled state at all", not "must do so in <120s".Test plan
dotnet run -c Release -f net472inTUnit.PublicAPI— 3/3 passed locally on Windows