feat(assertions): IsEqualTo with implicitly-convertible wrappers (#5720)

TUnit.Assertions.Analyzers.Tests/CollectionIsEqualToAnalyzerTests.cs

@@ -4,6 +4,13 @@ namespace TUnit.Assertions.Analyzers.Tests;
 
 public class CollectionIsEqualToAnalyzerTests
 {
+    // NOTE: Snippets that pass an expected of the same type as the source use the
+    // explicit type argument `IsEqualTo<T>(...)` so the analyzer-test compiler
+    // (Roslyn 4.8 — bound by the testing harness) does not raise CS0121 between
+    // the source-generated `IsEqualTo<TValue>` and the implicit-conversion-aware
+    // `IsEqualTo<TValue, TOther>`. Roslyn 4.12+ honours [OverloadResolutionPriority]
+    // and disambiguates automatically, so this is purely a test-infrastructure
+    // workaround and does not affect users.
     [Test]
     public async Task List_IsEqualTo_Raises_Info()
     {
@@ -23,7 +30,7 @@ public async Task Test()
                     {
                         var a = new List<int> { 1, 2, 3 };
                         var b = new List<int> { 1, 2, 3 };
-                        await Assert.That(a).{|#0:IsEqualTo(b)|};
+                        await Assert.That(a).{|#0:IsEqualTo<List<int>>(b)|};
                     }
                 }
                 """,
@@ -93,7 +100,7 @@ public async Task Test()
                     {
                         int[] a = { 1, 2 };
                         int[] b = { 1, 2 };
-                        await Assert.That(a).{|#0:IsEqualTo(b)|};
+                        await Assert.That(a).{|#0:IsEqualTo<int[]>(b)|};
                     }
                 }
                 """,

TUnit.Assertions.Analyzers.Tests/PreferIsTrueOrIsFalseAnalyzerTests.cs

@@ -4,6 +4,12 @@ namespace TUnit.Assertions.Analyzers.Tests;
 
 public class PreferIsTrueOrIsFalseAnalyzerTests
 {
+    // NOTE: Snippets use the explicit type argument `IsEqualTo<bool>(...)` so the
+    // analyzer-test compiler (Roslyn 4.8 — bound by the testing harness) does not
+    // raise CS0121 between the source-generated `IsEqualTo<TValue>` and the
+    // implicit-conversion-aware `IsEqualTo<TValue, TOther>`. Roslyn 4.12+ honours
+    // [OverloadResolutionPriority] and disambiguates without the explicit arg, so
+    // this is purely a test-infrastructure workaround and does not affect users.
     [Test]
     public async Task IsEqualTo_True_Is_Flagged()
     {
@@ -21,7 +27,7 @@ public class MyClass
                     public async Task MyTest()
                     {
                         var value = true;
-                        await {|#0:Assert.That(value).IsEqualTo(true)|};
+                        await {|#0:Assert.That(value).IsEqualTo<bool>(true)|};
                     }
                 }
                 """,
@@ -49,7 +55,7 @@ public class MyClass
                     public async Task MyTest()
                     {
                         var value = false;
-                        await {|#0:Assert.That(value).IsEqualTo(false)|};
+                        await {|#0:Assert.That(value).IsEqualTo<bool>(false)|};
                     }
                 }
                 """,

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.AssertionWithDefaultValues.DotNet10_0.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for DefaultValuesAssertion.
 /// </summary>
-public static class DefaultValuesAssertionExtensions
+public static partial class DefaultValuesAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.AssertionWithDefaultValues.DotNet8_0.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for DefaultValuesAssertion.
 /// </summary>
-public static class DefaultValuesAssertionExtensions
+public static partial class DefaultValuesAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.AssertionWithDefaultValues.DotNet9_0.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for DefaultValuesAssertion.
 /// </summary>
-public static class DefaultValuesAssertionExtensions
+public static partial class DefaultValuesAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.AssertionWithDefaultValues.Net4_7.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for DefaultValuesAssertion.
 /// </summary>
-public static class DefaultValuesAssertionExtensions
+public static partial class DefaultValuesAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.AssertionWithEnumDefault.DotNet10_0.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for StringComparisonAssertion.
 /// </summary>
-public static class StringComparisonAssertionExtensions
+public static partial class StringComparisonAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.AssertionWithEnumDefault.DotNet8_0.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for StringComparisonAssertion.
 /// </summary>
-public static class StringComparisonAssertionExtensions
+public static partial class StringComparisonAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.AssertionWithEnumDefault.DotNet9_0.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for StringComparisonAssertion.
 /// </summary>
-public static class StringComparisonAssertionExtensions
+public static partial class StringComparisonAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.AssertionWithEnumDefault.Net4_7.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for StringComparisonAssertion.
 /// </summary>
-public static class StringComparisonAssertionExtensions
+public static partial class StringComparisonAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.AssertionWithGenericConstraints.DotNet10_0.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for GreaterThanAssertion.
 /// </summary>
-public static class GreaterThanAssertionExtensions
+public static partial class GreaterThanAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.AssertionWithGenericConstraints.DotNet8_0.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for GreaterThanAssertion.
 /// </summary>
-public static class GreaterThanAssertionExtensions
+public static partial class GreaterThanAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.AssertionWithGenericConstraints.DotNet9_0.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for GreaterThanAssertion.
 /// </summary>
-public static class GreaterThanAssertionExtensions
+public static partial class GreaterThanAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.AssertionWithGenericConstraints.Net4_7.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for GreaterThanAssertion.
 /// </summary>
-public static class GreaterThanAssertionExtensions
+public static partial class GreaterThanAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.AssertionWithMultipleConstructors.DotNet10_0.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for EqualsAssertion.
 /// </summary>
-public static class EqualsAssertionExtensions
+public static partial class EqualsAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.AssertionWithMultipleConstructors.DotNet8_0.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for EqualsAssertion.
 /// </summary>
-public static class EqualsAssertionExtensions
+public static partial class EqualsAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.AssertionWithMultipleConstructors.DotNet9_0.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for EqualsAssertion.
 /// </summary>
-public static class EqualsAssertionExtensions
+public static partial class EqualsAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.AssertionWithMultipleConstructors.Net4_7.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for EqualsAssertion.
 /// </summary>
-public static class EqualsAssertionExtensions
+public static partial class EqualsAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.AssertionWithMultipleParameters.DotNet10_0.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for BetweenAssertion.
 /// </summary>
-public static class BetweenAssertionExtensions
+public static partial class BetweenAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.AssertionWithMultipleParameters.DotNet8_0.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for BetweenAssertion.
 /// </summary>
-public static class BetweenAssertionExtensions
+public static partial class BetweenAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.AssertionWithMultipleParameters.DotNet9_0.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for BetweenAssertion.
 /// </summary>
-public static class BetweenAssertionExtensions
+public static partial class BetweenAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.AssertionWithMultipleParameters.Net4_7.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for BetweenAssertion.
 /// </summary>
-public static class BetweenAssertionExtensions
+public static partial class BetweenAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.AssertionWithNegatedMethod.DotNet10_0.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for TrueAssertion.
 /// </summary>
-public static class TrueAssertionExtensions
+public static partial class TrueAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.AssertionWithNegatedMethod.DotNet8_0.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for TrueAssertion.
 /// </summary>
-public static class TrueAssertionExtensions
+public static partial class TrueAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.AssertionWithNegatedMethod.DotNet9_0.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for TrueAssertion.
 /// </summary>
-public static class TrueAssertionExtensions
+public static partial class TrueAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.AssertionWithNegatedMethod.Net4_7.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for TrueAssertion.
 /// </summary>
-public static class TrueAssertionExtensions
+public static partial class TrueAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.AssertionWithOptionalParameter.DotNet10_0.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for NotEqualsAssertion.
 /// </summary>
-public static class NotEqualsAssertionExtensions
+public static partial class NotEqualsAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.AssertionWithOptionalParameter.DotNet8_0.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for NotEqualsAssertion.
 /// </summary>
-public static class NotEqualsAssertionExtensions
+public static partial class NotEqualsAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.AssertionWithOptionalParameter.DotNet9_0.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for NotEqualsAssertion.
 /// </summary>
-public static class NotEqualsAssertionExtensions
+public static partial class NotEqualsAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.AssertionWithOptionalParameter.Net4_7.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for NotEqualsAssertion.
 /// </summary>
-public static class NotEqualsAssertionExtensions
+public static partial class NotEqualsAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.MultipleGenericParameters.DotNet10_0.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for IsAssignableToAssertion.
 /// </summary>
-public static class IsAssignableToAssertionExtensions
+public static partial class IsAssignableToAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.MultipleGenericParameters.DotNet8_0.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for IsAssignableToAssertion.
 /// </summary>
-public static class IsAssignableToAssertionExtensions
+public static partial class IsAssignableToAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.MultipleGenericParameters.DotNet9_0.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for IsAssignableToAssertion.
 /// </summary>
-public static class IsAssignableToAssertionExtensions
+public static partial class IsAssignableToAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.MultipleGenericParameters.Net4_7.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for IsAssignableToAssertion.
 /// </summary>
-public static class IsAssignableToAssertionExtensions
+public static partial class IsAssignableToAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.NonGenericAssertion.DotNet10_0.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for StringIsEmptyAssertion.
 /// </summary>
-public static class StringIsEmptyAssertionExtensions
+public static partial class StringIsEmptyAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.NonGenericAssertion.DotNet8_0.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for StringIsEmptyAssertion.
 /// </summary>
-public static class StringIsEmptyAssertionExtensions
+public static partial class StringIsEmptyAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.NonGenericAssertion.DotNet9_0.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for StringIsEmptyAssertion.
 /// </summary>
-public static class StringIsEmptyAssertionExtensions
+public static partial class StringIsEmptyAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.NonGenericAssertion.Net4_7.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for StringIsEmptyAssertion.
 /// </summary>
-public static class StringIsEmptyAssertionExtensions
+public static partial class StringIsEmptyAssertionExtensions
 {
 
     /// <summary>

TUnit.Assertions.SourceGenerator.Tests/AssertionExtensionGeneratorTests.SingleGenericParameter.DotNet10_0.verified.txt

@@ -12,7 +12,7 @@ namespace TUnit.Assertions.Extensions;
 /// <summary>
 /// Generated extension methods for NullAssertion.
 /// </summary>
-public static class NullAssertionExtensions
+public static partial class NullAssertionExtensions
 {
 
     /// <summary>