Skip to content

fix(analyzers): remove incorrect AOT rules TUnit0300/0301/0302 (#5722) #5746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 1 commit into from
Apr 26, 2026
Merged

fix(analyzers): remove incorrect AOT rules TUnit0300/0301/0302 (#5722) #5746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
127 changes: 0 additions & 127 deletions TUnit.Analyzers.Tests/AotCompatibilityAnalyzerTests.cs
View file
Open in desktop

This file was deleted.

5 changes: 4 additions & 1 deletion TUnit.Analyzers/AnalyzerReleases.Unshipped.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,7 @@ TUnit0074 | Usage | Error | Hook attribute is redundant on an override
Rule ID | Category | Severity | Notes
--------|----------|----------|-------
TUnit0015 | Usage | Error | Changed to Warning severity (CancellationToken parameter now optional)
TUnit0043 | Usage | Error | Changed to Info severity (now a suggestion instead of error)
TUnit0043 | Usage | Error | Changed to Info severity (now a suggestion instead of error)
TUnit0300 | Usage | Warning | Removed - rule was inaccurate and produced false positives
TUnit0301 | Usage | Warning | Removed - rule was inaccurate and produced false positives
TUnit0302 | Usage | Warning | Removed - rule was never implemented and the underlying claim was inaccurate
130 changes: 0 additions & 130 deletions TUnit.Analyzers/AotCompatibilityAnalyzer.cs
View file
Open in desktop

This file was deleted.

27 changes: 0 additions & 27 deletions TUnit.Analyzers/Resources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,15 +507,6 @@
<data name="TUnit0062Title" xml:space="preserve">
<value>CancellationToken must be the last parameter</value>
</data>
<data name="TUnit0300Description" xml:space="preserve">
<value>Generic types and methods may not be AOT-compatible when using dynamic type creation. Consider using concrete types or ensure all generic combinations are known at compile time.</value>
</data>
<data name="TUnit0300MessageFormat" xml:space="preserve">
<value>{0} may not be AOT-compatible. All generic type combinations must be known at compile time.</value>
</data>
<data name="TUnit0300Title" xml:space="preserve">
<value>Generic type or method may not be AOT-compatible</value>
</data>
<data name="TUnit0052Description" xml:space="preserve">
<value>When a test class has multiple constructors, one should be marked with [TestConstructor] to avoid ambiguity.</value>
</data>
Expand Down Expand Up @@ -543,22 +534,4 @@
<data name="TUnit0074Title" xml:space="preserve">
<value>Hook attribute is redundant on an override</value>
</data>
<data name="TUnit0301Description" xml:space="preserve">
<value>Tuple types require reflection for property/field access which is not AOT-compatible. Consider using concrete types or value deconstruction.</value>
</data>
<data name="TUnit0301MessageFormat" xml:space="preserve">
<value>{0} uses reflection which is not AOT-compatible. Consider using concrete types instead of tuples.</value>
</data>
<data name="TUnit0301Title" xml:space="preserve">
<value>Tuple usage may not be AOT-compatible</value>
</data>
<data name="TUnit0302Description" xml:space="preserve">
<value>Custom conversion operators (op_Implicit/op_Explicit) require runtime discovery which is not AOT-compatible. Use explicit casting or standard conversions.</value>
</data>
<data name="TUnit0302MessageFormat" xml:space="preserve">
<value>{0} invocation may not be AOT-compatible. Use explicit casting or standard conversions instead.</value>
</data>
<data name="TUnit0302Title" xml:space="preserve">
<value>Custom conversion operator may not be AOT-compatible</value>
</data>
</root>
7 changes: 0 additions & 7 deletions TUnit.Analyzers/Rules.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,13 +176,6 @@ public static class Rules
public static readonly DiagnosticDescriptor RedundantHookAttributeOnOverride =
CreateDescriptor("TUnit0074", UsageCategory, DiagnosticSeverity.Error);

public static readonly DiagnosticDescriptor GenericTypeNotAotCompatible =
CreateDescriptor("TUnit0300", UsageCategory, DiagnosticSeverity.Warning);

public static readonly DiagnosticDescriptor TupleNotAotCompatible =
CreateDescriptor("TUnit0301", UsageCategory, DiagnosticSeverity.Warning);


private static DiagnosticDescriptor CreateDescriptor(string diagnosticId, string category, DiagnosticSeverity severity,
string[]? customTags = null, string? helpLinkUri = null)
{
Expand Down
Loading