chore(deps): update opentelemetry to 1.15.3#5645
Conversation
There was a problem hiding this comment.
Code Review: chore(deps): update opentelemetry to 1.15.3
This is a straightforward Renovate Bot patch bump of four OpenTelemetry packages from 1.15.2 → 1.15.3. The changes are correct and consistent.
What's Good
The Directory.Packages.props update keeps all four packages in sync at the same version, which is exactly what Central Package Management (CPM) is for. Good hygiene.
One Architectural Observation
The template and example .csproj files (ExampleNamespace.ServiceDefaults.csproj and CloudShop.ServiceDefaults.csproj) use explicit inline version pins rather than deferring to Directory.Packages.props:
<PackageReference Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.15.3" />This means every Renovate bump has to touch three files instead of one. For the example project (CloudShop) this is a clear improvement opportunity — it lives in the repo and could simply inherit from CPM with no Version= attribute at all.
The template project (TUnit.Aspire.Starter) is a different story: because users scaffold it into a standalone solution that won't have the root Directory.Packages.props, explicit pinning is intentional and correct there. No change needed for the template.
Suggestion for examples/CloudShop: Remove the Version= attributes on packages already declared in Directory.Packages.props. That would mean future bumps like this only need one file change. This is not a blocker for this PR — just worth a follow-up issue to tidy up.
Notable Items in 1.15.3 Release Notes
Two items worth being aware of (neither affects this repo's usage, but good to flag):
- Breaking:
tracestatekeys beginning with digits are now rejected per W3C spec. No impact unless any test fixtures use such keys. - Breaking: Disk retry for OTLP now requires an explicit directory path env var. No impact unless that experimental feature is in use.
Summary
Approving — the change is correct, well-scoped, and safe to merge. The inline version pins in CloudShop are a pre-existing pattern worth cleaning up separately.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
This PR contains the following updates:
1.15.2→1.15.31.15.2→1.15.31.15.2→1.15.31.15.2→1.15.3Release Notes
open-telemetry/opentelemetry-dotnet (OpenTelemetry)
v1.15.3Release details: 1.15.3
tracestateparsing to reject keys that do notbegin with a lowercase letter, including keys beginning with digits, to
align with the W3C Trace Context specification.
Disk retry now requires
OTEL_DOTNET_EXPERIMENTAL_OTLP_DISK_RETRY_DIRECTORY_PATHwhen
OTEL_DOTNET_EXPERIMENTAL_OTLP_RETRY=diskis configured.OtlpLogExporternow usesIHttpClientFactoryon .NET 8+.OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMITnot being applied.BaggagePropagatorto trim optional whitespace (OWS) around=separators when parsing the
baggageheader.BaggagePropagatorto strip baggage properties from values whenparsing the
baggageheader.LogRecord.LogLevelto preserveLogLevel.None.OTEL_TRACES_SAMPLER_ARGhandling for out-of-range values.traces storage directory.
serialization.
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Renovate Bot.