Skip to content

fix(pipeline): isolate AOT publish outputs to stop clobbering pack DLLs (#5622) #5624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 5 commits into from
Apr 18, 2026
Merged

fix(pipeline): isolate AOT publish outputs to stop clobbering pack DLLs (#5622) #5624

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
566d06a
fix(pipeline): isolate AOT publish outputs to stop overwriting packab…
thomhurst Apr 18, 2026
43f319d
fix(ci): isolate TestProject AOT publish from main bin/Release (#5622)
thomhurst Apr 18, 2026
71551e9
docs(pipeline): note concurrency invariant with AOT publish modules (…
thomhurst Apr 18, 2026
0e35e1f
refactor(pipeline): trim #5622 comments to essential WHY
thomhurst Apr 18, 2026
7323bd5
fix(ci): propagate version props via env vars + serialize pack after AOT
thomhurst Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions TUnit.Pipeline/Modules/PublishMockTestsAOTModule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,14 @@ protected override ModuleConfiguration Configure() => ModuleConfiguration.Create
Properties =
[
new KeyValue("Aot", "true"),
// Redirect build outputs into a per-framework tree so the AOT re-compile
// of ProjectReferences (TUnit.Mocks, TUnit.Mocks.Assertions) never
// overwrites the main bin/Release DLLs that PackTUnitFilesModule packages
// with --no-build. Without this, the re-compile drops AssemblyVersion back
// to 1.0.0.0 (CI passes AssemblyVersion only to the initial solution build),
// shipping strong-name-mismatched NuGet packages (issue #5622).
new KeyValue("BaseOutputPath", $"bin/aot-{framework}/"),
new KeyValue("BaseIntermediateOutputPath", $"obj/aot-{framework}/"),
],
Framework = framework,
}, new CommandExecutionOptions
Expand Down
6 changes: 5 additions & 1 deletion TUnit.Pipeline/Modules/PublishNugetTesterAOTModule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,11 @@ protected override ModuleConfiguration Configure() => ModuleConfiguration.Create
Properties =
[
new KeyValue("Aot", "true"),
new KeyValue("TUnitVersion", version.ValueOrDefault!.SemVer!)
new KeyValue("TUnitVersion", version.ValueOrDefault!.SemVer!),
// Isolate AOT publish outputs from the main bin/Release so packable
// projects' DLLs are never rewritten by this publish (issue #5622).
new KeyValue("BaseOutputPath", $"bin/aot-{framework}/"),
new KeyValue("BaseIntermediateOutputPath", $"obj/aot-{framework}/"),
],
Framework = framework,
}, new CommandExecutionOptions
Expand Down
Loading