Conversation
thomhurst
added
dependencies
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Dependency Update Review: TUnit 1.33.0 → 1.34.0
This is a Renovate-generated dependency bump updating 7 TUnit packages (TUnit, TUnit.AspNetCore, TUnit.Assertions, TUnit.Assertions.FSharp, TUnit.Core, TUnit.Engine, TUnit.Playwright) from 1.33.0 to 1.34.0 across Directory.Packages.props and the template project files.
What changed in 1.34.0
Based on the release notes, the notable functional changes in 1.34.0 include:
refactor: move CorrelatedTUnitLogger to TUnit.Logging.Microsoft and auto-inject handlers(#5532)feat: cross-process test log correlation via OTLP receiver(#5533)fix: start session activity before discovery so discovery spans parent correctly(#5534)refactor: use natural OTEL trace propagation instead of synthetic TraceIds(#5557)fix: route ITestOutput writes through synchronized ConcurrentStringWriter(#5558)
The ITestOutput concurrency fix (#5558) and the OTEL session span ordering fix (#5534) are particularly meaningful correctness improvements worth picking up.
Observations and Concerns
Inconsistent version pinning across template projects
The diff updates 5 template project files, but two template projects are not updated and have diverged from the others:
TUnit.Templates/content/TUnit/TestProject.csproj— uses a floating version"1.*", so it picks up any1.xrelease automatically and is unaffected.TUnit.Templates/content/TUnit.Aspire.Starter/ExampleNamespace.TestProject/ExampleNamespace.TestProject.csproj— pinned toTUnit.Aspire1.14.0, a completely different package not in scope here.TUnit.Templates/content/TUnit.Aspire.Test/ExampleNamespace.csproj— same, pinned toTUnit.Aspire1.14.0.
The two Aspire template projects referencing TUnit.Aspire at 1.14.0 look significantly stale relative to the 1.34.0 packages being updated here. It would be worth checking whether TUnit.Aspire has also released updates that should accompany this bump.
Directory.Packages.props vs. template project files — dual version management
The template project files (TUnit.Templates/content/*/TestProject.*proj) pin their own explicit versions independent of Directory.Packages.props. This creates a maintenance burden: each Renovate bump must update both the central props file and each template project file individually. Some template projects use Version="1.*" (the floating wildcard), while others use hard pins. A more consistent approach across all templates would reduce the chance of partial updates slipping through.
Consider whether the template project files should all adopt Version="1.*" (as TUnit/TestProject.csproj already does), which would eliminate the need for Renovate to touch those files on every minor release. Since these are starter templates rather than production code, a floating 1.* constraint is a reasonable end-user experience.
No source-gen / reflection mode impact
This PR only changes package version numbers and has no effect on the source generator, reflection engine, or any runtime behaviour. The dual-mode requirement and AOT compatibility concerns do not apply here.
Auto-merge is enabled — appropriate for this PR
Given that this is a patch-level dependency update to TUnit's own packages (essentially self-referential: the repo itself depends on its own published NuGet), auto-merge via squash is appropriate. CI checks (integration-tests, modularpipeline across platforms) will gate the merge.
Summary
The update is correct and straightforward. The only actionable items to consider:
- Check
TUnit.Aspireversions inTUnit.Aspire.StarterandTUnit.Aspire.Testtemplates —1.14.0looks stale. - Consider standardizing template project version constraints to
1.*(floating) to reduce the number of files Renovate must touch on every minor release.
No blocking issues. This is a routine, safe dependency bump.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
2 participants
This PR contains the following updates:
1.33.0→1.34.01.33.0→1.34.01.33.0→1.34.01.33.0→1.34.01.33.0→1.34.01.33.0→1.34.01.33.0→1.34.0Release Notes
thomhurst/TUnit (TUnit)
v1.34.0: 1.34.0What's Changed
Other Changes
Dependencies
Full Changelog: v1.33.0...v1.34.0
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Renovate Bot.