Skip to content

fix(mocks): skip inaccessible internal accessors when mocking Azure.Response #5461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 3 commits into from
Apr 8, 2026
Merged

fix(mocks): skip inaccessible internal accessors when mocking Azure.Response #5461

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2d6f08
fix(mocks): skip inaccessible internal accessors when mocking Azure.R…
thomhurst Apr 8, 2026
a56589d
fix(mocks): also block private accessors on external virtual properties
thomhurst Apr 8, 2026
7c6f44e
chore(mocks): tighten comments and test name from simplify review
thomhurst Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 39 additions & 26 deletions TUnit.Mocks.SourceGenerator/Discovery/MemberDiscovery.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,13 @@ public static (EquatableArray<MockMemberModel> Methods, EquatableArray<MockMembe
{
if (existingIndex.HasValue)
{
MergePropertyAccessors(properties, existingIndex.Value, property, ref memberIdCounter);
MergePropertyAccessors(properties, existingIndex.Value, property, ref memberIdCounter, compilationAssembly);
}
}
else
{
seenProperties[key] = properties.Count;
properties.Add(CreatePropertyModel(property, ref memberIdCounter, explicitInterfaceName, interfaceFqn));
properties.Add(CreatePropertyModel(property, ref memberIdCounter, explicitInterfaceName, interfaceFqn, compilationAssembly));
}
break;
}
Expand All @@ -93,13 +93,13 @@ public static (EquatableArray<MockMemberModel> Methods, EquatableArray<MockMembe
{
if (existingIndex.HasValue)
{
MergePropertyAccessors(properties, existingIndex.Value, indexer, ref memberIdCounter);
MergePropertyAccessors(properties, existingIndex.Value, indexer, ref memberIdCounter, compilationAssembly);
}
}
else
{
seenProperties[key] = properties.Count;
properties.Add(CreateIndexerModel(indexer, ref memberIdCounter, explicitInterfaceName, interfaceFqn));
properties.Add(CreateIndexerModel(indexer, ref memberIdCounter, explicitInterfaceName, interfaceFqn, compilationAssembly));
}
break;
}
Expand Down Expand Up @@ -179,13 +179,13 @@ public static (EquatableArray<MockMemberModel> Methods, EquatableArray<MockMembe
{
if (existingIndex.HasValue)
{
MergePropertyAccessors(properties, existingIndex.Value, property, ref memberIdCounter);
MergePropertyAccessors(properties, existingIndex.Value, property, ref memberIdCounter, compilationAssembly);
}
}
else
{
seenProperties[key] = properties.Count;
properties.Add(CreatePropertyModel(property, ref memberIdCounter, null, declaringInterfaceName: interfaceFqn));
properties.Add(CreatePropertyModel(property, ref memberIdCounter, null, declaringInterfaceName: interfaceFqn, compilationAssembly: compilationAssembly));
}
break;
}
Expand All @@ -198,13 +198,13 @@ public static (EquatableArray<MockMemberModel> Methods, EquatableArray<MockMembe
{
if (existingIndex.HasValue)
{
MergePropertyAccessors(properties, existingIndex.Value, indexer, ref memberIdCounter);
MergePropertyAccessors(properties, existingIndex.Value, indexer, ref memberIdCounter, compilationAssembly);
}
}
else
{
seenProperties[key] = properties.Count;
properties.Add(CreateIndexerModel(indexer, ref memberIdCounter, null, declaringInterfaceName: interfaceFqn));
properties.Add(CreateIndexerModel(indexer, ref memberIdCounter, null, declaringInterfaceName: interfaceFqn, compilationAssembly: compilationAssembly));
}
break;
}
Expand Down Expand Up @@ -292,13 +292,13 @@ private static void ProcessClassMembers(
{
if (existingIndex.HasValue)
{
MergePropertyAccessors(properties, existingIndex.Value, property, ref memberIdCounter);
MergePropertyAccessors(properties, existingIndex.Value, property, ref memberIdCounter, compilationAssembly);
}
}
else
{
seenProperties[key] = properties.Count;
properties.Add(CreatePropertyModel(property, ref memberIdCounter, null));
properties.Add(CreatePropertyModel(property, ref memberIdCounter, null, compilationAssembly: compilationAssembly));
}
}
else if (!seenProperties.ContainsKey(key))
Expand All @@ -318,13 +318,13 @@ private static void ProcessClassMembers(
{
if (existingIndex.HasValue)
{
MergePropertyAccessors(properties, existingIndex.Value, indexer, ref memberIdCounter);
MergePropertyAccessors(properties, existingIndex.Value, indexer, ref memberIdCounter, compilationAssembly);
}
}
else
{
seenProperties[key] = properties.Count;
properties.Add(CreateIndexerModel(indexer, ref memberIdCounter, null));
properties.Add(CreateIndexerModel(indexer, ref memberIdCounter, null, compilationAssembly: compilationAssembly));
}
}
else if (!seenProperties.ContainsKey(key))
Expand Down Expand Up @@ -532,27 +532,38 @@ private static MockMemberModel CreateMethodModel(IMethodSymbol method, ref int m
/// accessors so the generated class satisfies all interfaces.
/// </summary>
private static void MergePropertyAccessors(List<MockMemberModel> properties, int existingIndex,
IPropertySymbol newProperty, ref int memberIdCounter)
IPropertySymbol newProperty, ref int memberIdCounter, IAssemblySymbol? compilationAssembly = null)
{
var existing = properties[existingIndex];
var needsGetter = !existing.HasGetter && newProperty.GetMethod is not null;
var needsSetter = !existing.HasSetter && newProperty.SetMethod is not null;
var newGetterAccessible = IsAccessorAccessible(newProperty.GetMethod, compilationAssembly);
var newSetterAccessible = IsAccessorAccessible(newProperty.SetMethod, compilationAssembly);
var needsGetter = !existing.HasGetter && newGetterAccessible;
var needsSetter = !existing.HasSetter && newSetterAccessible;

if (!needsGetter && !needsSetter) return;

properties[existingIndex] = existing with
{
HasGetter = existing.HasGetter || newProperty.GetMethod is not null,
HasSetter = existing.HasSetter || newProperty.SetMethod is not null,
HasGetter = existing.HasGetter || newGetterAccessible,
HasSetter = existing.HasSetter || newSetterAccessible,
SetterMemberId = existing.HasSetter ? existing.SetterMemberId
: newProperty.SetMethod is not null ? memberIdCounter++ : existing.SetterMemberId
: newSetterAccessible ? memberIdCounter++ : existing.SetterMemberId
};
}

private static MockMemberModel CreatePropertyModel(IPropertySymbol property, ref int memberIdCounter, string? explicitInterfaceName, string? declaringInterfaceName = null)
/// <summary>
/// Returns true if the accessor exists AND is accessible from the compilation assembly.
/// Needed because e.g. `internal set` on an external type exists in the symbol but can't be overridden.
/// </summary>
private static bool IsAccessorAccessible(IMethodSymbol? accessor, IAssemblySymbol? compilationAssembly)
=> accessor is not null && IsMemberAccessible(accessor, compilationAssembly);

private static MockMemberModel CreatePropertyModel(IPropertySymbol property, ref int memberIdCounter, string? explicitInterfaceName, string? declaringInterfaceName = null, IAssemblySymbol? compilationAssembly = null)
{
var hasGetter = IsAccessorAccessible(property.GetMethod, compilationAssembly);
var hasSetter = IsAccessorAccessible(property.SetMethod, compilationAssembly);
var getterId = memberIdCounter++;
var setterId = property.SetMethod is not null ? memberIdCounter++ : 0;
var setterId = hasSetter ? memberIdCounter++ : 0;

return new MockMemberModel
{
Expand All @@ -563,8 +574,8 @@ private static MockMemberModel CreatePropertyModel(IPropertySymbol property, ref
IsVoid = false,
IsAsync = false,
IsProperty = true,
HasGetter = property.GetMethod is not null,
HasSetter = property.SetMethod is not null,
HasGetter = hasGetter,
HasSetter = hasSetter,
SetterMemberId = setterId,
ExplicitInterfaceName = explicitInterfaceName,
DeclaringInterfaceName = declaringInterfaceName,
Expand Down Expand Up @@ -613,10 +624,12 @@ public static EquatableArray<MockConstructorModel> DiscoverConstructors(INamedTy
return new EquatableArray<MockConstructorModel>(constructors.ToImmutableArray());
}

private static MockMemberModel CreateIndexerModel(IPropertySymbol indexer, ref int memberIdCounter, string? explicitInterfaceName, string? declaringInterfaceName = null)
private static MockMemberModel CreateIndexerModel(IPropertySymbol indexer, ref int memberIdCounter, string? explicitInterfaceName, string? declaringInterfaceName = null, IAssemblySymbol? compilationAssembly = null)
{
var hasGetter = IsAccessorAccessible(indexer.GetMethod, compilationAssembly);
var hasSetter = IsAccessorAccessible(indexer.SetMethod, compilationAssembly);
var getterId = memberIdCounter++;
var setterId = indexer.SetMethod is not null ? memberIdCounter++ : 0;
var setterId = hasSetter ? memberIdCounter++ : 0;

return new MockMemberModel
{
Expand All @@ -629,8 +642,8 @@ private static MockMemberModel CreateIndexerModel(IPropertySymbol indexer, ref i
IsAsync = false,
IsProperty = true,
IsIndexer = true,
HasGetter = indexer.GetMethod is not null,
HasSetter = indexer.SetMethod is not null,
HasGetter = hasGetter,
HasSetter = hasSetter,
Parameters = new EquatableArray<MockParameterModel>(
indexer.Parameters.Select(p => new MockParameterModel
{
Expand Down
16 changes: 16 additions & 0 deletions TUnit.Mocks.Tests/Issue5455Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
using Azure;

namespace TUnit.Mocks.Tests;

// Regression: https://github.com/thomhurst/TUnit/issues/5455
// Azure.Response.IsError is `public virtual bool IsError { get; internal set; }` — the internal
// setter is invisible to external assemblies, so the generated override must not emit it.
public class Issue5455Tests
{
[Test]
public void Mocking_Response_With_Internal_Setter_Compiles()
{
var mock = Mock.Of<Response>(MockBehavior.Strict);
_ = mock.Object;
}
}
Loading