Skip to content

Perf: Generate typed HandleCall<T1,...> overloads to eliminate argument boxing #5399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 8 commits into from
Apr 5, 2026
Merged

Perf: Generate typed HandleCall<T1,...> overloads to eliminate argument boxing #5399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
513658f
feat(mocks): add typed ArgumentStore structs for zero-boxing arg storage
thomhurst Apr 5, 2026
595f6df
feat(mocks): add typed matching and deferred-boxing CallRecord
thomhurst Apr 5, 2026
aac2656
feat(mocks): add typed HandleCall overloads in MockEngine.Typed.cs
thomhurst Apr 5, 2026
f89a88c
feat(mocks): source generator emits typed HandleCall dispatch for ari…
thomhurst Apr 5, 2026
b806bde
test(mocks): update snapshots for typed HandleCall dispatch
thomhurst Apr 5, 2026
c35ee34
fix(mocks): make CallRecord constructors public for test and generate…
thomhurst Apr 5, 2026
b9e2c36
refactor(mocks): extract RecordCall common logic, remove noisy comments
thomhurst Apr 5, 2026
87b900d
refactor(mocks): address review feedback
thomhurst Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ....Mocks.SourceGenerator.Tests/Snapshots/Generic_Interface_Extension_Discovery.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@ namespace TUnit.Mocks.Generated

public string GetById(int id)
{
return _engine.HandleCallWithReturn<string>(0, "GetById", new object?[] { id }, "");
return _engine.HandleCallWithReturn<string, int>(0, "GetById", id, "");
}

public void Save(string entity)
{
_engine.HandleCall(1, "Save", new object?[] { entity });
_engine.HandleCall<string>(1, "Save", entity);
}

[global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
Expand Down
2 changes: 1 addition & 1 deletion ...cks.SourceGenerator.Tests/Snapshots/Interface_Inheriting_Multiple_Interfaces.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ namespace TUnit.Mocks.Generated

public void Write(string data)
{
_engine.HandleCall(2, "Write", new object?[] { data });
_engine.HandleCall<string>(2, "Write", data);
}

[global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
Expand Down
6 changes: 3 additions & 3 deletions TUnit.Mocks.SourceGenerator.Tests/Snapshots/Interface_With_Async_Methods.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ namespace TUnit.Mocks.Generated
{
try
{
var __result = _engine.HandleCallWithReturn<string>(0, "GetValueAsync", new object?[] { key }, "");
var __result = _engine.HandleCallWithReturn<string, string>(0, "GetValueAsync", key, "");
if (global::TUnit.Mocks.Setup.RawReturnContext.TryConsume(out var __rawAsync))
{
if (__rawAsync is global::System.Threading.Tasks.Task<string> __typedAsync) return __typedAsync;
Expand Down Expand Up @@ -79,7 +79,7 @@ namespace TUnit.Mocks.Generated
{
try
{
var __result = _engine.HandleCallWithReturn<int>(2, "ComputeAsync", new object?[] { input }, default);
var __result = _engine.HandleCallWithReturn<int, int>(2, "ComputeAsync", input, default);
if (global::TUnit.Mocks.Setup.RawReturnContext.TryConsume(out var __rawAsync))
{
if (__rawAsync is global::System.Threading.Tasks.ValueTask<int> __typedAsync) return __typedAsync;
Expand All @@ -97,7 +97,7 @@ namespace TUnit.Mocks.Generated
{
try
{
_engine.HandleCall(3, "InitializeAsync", new object?[] { ct });
_engine.HandleCall<global::System.Threading.CancellationToken>(3, "InitializeAsync", ct);
if (global::TUnit.Mocks.Setup.RawReturnContext.TryConsume(out var __rawAsync))
{
if (__rawAsync is global::System.Threading.Tasks.ValueTask __typedAsync) return __typedAsync;
Expand Down
2 changes: 1 addition & 1 deletion TUnit.Mocks.SourceGenerator.Tests/Snapshots/Interface_With_Events.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ namespace TUnit.Mocks.Generated

public void Notify(string message)
{
_engine.HandleCall(0, "Notify", new object?[] { message });
_engine.HandleCall<string>(0, "Notify", message);
}

private global::System.EventHandler<string>? _backing_ItemAdded;
Expand Down
6 changes: 3 additions & 3 deletions TUnit.Mocks.SourceGenerator.Tests/Snapshots/Interface_With_Generic_Methods.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,17 +42,17 @@ namespace TUnit.Mocks.Generated

public T GetById<T>(int id) where T : class
{
return _engine.HandleCallWithReturn<T>(0, "GetById", new object?[] { id }, default!);
return _engine.HandleCallWithReturn<T, int>(0, "GetById", id, default!);
}

public void Save<T>(T entity) where T : class, new()
{
_engine.HandleCall(1, "Save", new object?[] { entity });
_engine.HandleCall<T>(1, "Save", entity);
}

public TResult Transform<TInput, TResult>(TInput input) where TInput : notnull where TResult : struct
{
return _engine.HandleCallWithReturn<TResult>(2, "Transform", new object?[] { input }, default);
return _engine.HandleCallWithReturn<TResult, TInput>(2, "Transform", input, default);
}

[global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
Expand Down
4 changes: 2 additions & 2 deletions ...Mocks.SourceGenerator.Tests/Snapshots/Interface_With_Keyword_Parameter_Names.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@ namespace TUnit.Mocks.Generated

public void Test(string @event)
{
_engine.HandleCall(0, "Test", new object?[] { @event });
_engine.HandleCall<string>(0, "Test", @event);
}

public string Get(int @class, string @return)
{
return _engine.HandleCallWithReturn<string>(1, "Get", new object?[] { @class, @return }, "");
return _engine.HandleCallWithReturn<string, int, string>(1, "Get", @class, @return, "");
}

[global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
Expand Down
4 changes: 2 additions & 2 deletions TUnit.Mocks.SourceGenerator.Tests/Snapshots/Interface_With_Mixed_Members.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ namespace TUnit.Mocks.Generated
{
try
{
var __result = _engine.HandleCallWithReturn<string>(3, "GetAsync", new object?[] { id }, "");
var __result = _engine.HandleCallWithReturn<string, int>(3, "GetAsync", id, "");
if (global::TUnit.Mocks.Setup.RawReturnContext.TryConsume(out var __rawAsync))
{
if (__rawAsync is global::System.Threading.Tasks.Task<string> __typedAsync) return __typedAsync;
Expand All @@ -95,7 +95,7 @@ namespace TUnit.Mocks.Generated

public void Process(string data)
{
_engine.HandleCall(4, "Process", new object?[] { data });
_engine.HandleCall<string>(4, "Process", data);
}

public string Name
Expand Down
8 changes: 4 additions & 4 deletions ...eGenerator.Tests/Snapshots/Interface_With_Nullable_Reference_Type_Parameters.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,24 +49,24 @@ namespace TUnit.Mocks.Generated

public void Bar(object? baz)
{
_engine.HandleCall(0, "Bar", new object?[] { baz });
_engine.HandleCall<object?>(0, "Bar", baz);
}

public string? GetValue(string? key, int count)
{
return _engine.HandleCallWithReturn<string?>(1, "GetValue", new object?[] { key, count }, default);
return _engine.HandleCallWithReturn<string?, string?, int>(1, "GetValue", key, count, default);
}

public void Process(string nonNull, string? nullable, object? obj)
{
_engine.HandleCall(2, "Process", new object?[] { nonNull, nullable, obj });
_engine.HandleCall<string, string?, object?>(2, "Process", nonNull, nullable, obj);
}

public global::System.Threading.Tasks.Task<string?> GetAsync(string? key)
{
try
{
var __result = _engine.HandleCallWithReturn<string?>(3, "GetAsync", new object?[] { key }, default);
var __result = _engine.HandleCallWithReturn<string?, string?>(3, "GetAsync", key, default);
if (global::TUnit.Mocks.Setup.RawReturnContext.TryConsume(out var __rawAsync))
{
if (__rawAsync is global::System.Threading.Tasks.Task<string?> __typedAsync) return __typedAsync;
Expand Down
4 changes: 2 additions & 2 deletions TUnit.Mocks.SourceGenerator.Tests/Snapshots/Interface_With_Out_Ref_Parameters.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ namespace TUnit.Mocks.Generated
public bool TryGetValue(string key, out string value)
{
value = default!;
var __result = _engine.HandleCallWithReturn<bool>(0, "TryGetValue", new object?[] { key }, default);
var __result = _engine.HandleCallWithReturn<bool, string>(0, "TryGetValue", key, default);
var __outRef = global::TUnit.Mocks.Setup.OutRefContext.Consume();
if (__outRef is not null)
{
Expand All @@ -52,7 +52,7 @@ namespace TUnit.Mocks.Generated

public void Swap(ref int a, ref int b)
{
_engine.HandleCall(1, "Swap", new object?[] { a, b });
_engine.HandleCall<int, int>(1, "Swap", a, b);
var __outRef = global::TUnit.Mocks.Setup.OutRefContext.Consume();
if (__outRef is not null)
{
Expand Down
8 changes: 4 additions & 4 deletions TUnit.Mocks.SourceGenerator.Tests/Snapshots/Interface_With_Overloaded_Methods.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,22 +41,22 @@ namespace TUnit.Mocks.Generated

public string Format(string value)
{
return _engine.HandleCallWithReturn<string>(0, "Format", new object?[] { value }, "");
return _engine.HandleCallWithReturn<string, string>(0, "Format", value, "");
}

public string Format(int value)
{
return _engine.HandleCallWithReturn<string>(1, "Format", new object?[] { value }, "");
return _engine.HandleCallWithReturn<string, int>(1, "Format", value, "");
}

public string Format(string template, string arg1)
{
return _engine.HandleCallWithReturn<string>(2, "Format", new object?[] { template, arg1 }, "");
return _engine.HandleCallWithReturn<string, string, string>(2, "Format", template, arg1, "");
}

public string Format(string template, string arg1, string arg2)
{
return _engine.HandleCallWithReturn<string>(3, "Format", new object?[] { template, arg1, arg2 }, "");
return _engine.HandleCallWithReturn<string, string, string, string>(3, "Format", template, arg1, arg2, "");
}

[global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
Expand Down
2 changes: 1 addition & 1 deletion ...erator.Tests/Snapshots/Interface_With_Static_Abstract_Transitive_Return_Type.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ namespace TUnit.Mocks.Generated

public string GetValue(string key)
{
return _engine.HandleCallWithReturn<string>(0, "GetValue", new object?[] { key }, "");
return _engine.HandleCallWithReturn<string, string>(0, "GetValue", key, "");
}

public global::IConfigProvider GetConfigProvider()
Expand Down
4 changes: 2 additions & 2 deletions TUnit.Mocks.SourceGenerator.Tests/Snapshots/Multi_Method_Interface.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,12 @@ namespace TUnit.Mocks.Generated

public int Add(int a, int b)
{
return _engine.HandleCallWithReturn<int>(0, "Add", new object?[] { a, b }, default);
return _engine.HandleCallWithReturn<int, int, int>(0, "Add", a, b, default);
}

public int Subtract(int a, int b)
{
return _engine.HandleCallWithReturn<int>(1, "Subtract", new object?[] { a, b }, default);
return _engine.HandleCallWithReturn<int, int, int>(1, "Subtract", a, b, default);
}

public void Reset()
Expand Down
2 changes: 1 addition & 1 deletion ...apshots/Partial_Mock_Filters_Internal_Virtual_Members_From_External_Assembly.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ namespace TUnit.Mocks.Generated.ExternalLib

public override string PublicMethod(string input)
{
if (_engine.TryHandleCallWithReturn<string>(0, "PublicMethod", new object?[] { input }, "", out var __result))
if (_engine.TryHandleCallWithReturn<string, string>(0, "PublicMethod", input, "", out var __result))
{
return __result;
}
Expand Down
2 changes: 1 addition & 1 deletion ...r.Tests/Snapshots/Partial_Mock_Filters_Members_With_Internal_Signature_Types.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ namespace TUnit.Mocks.Generated.ExternalLib

public override string GetValue(string key)
{
if (_engine.TryHandleCallWithReturn<string>(0, "GetValue", new object?[] { key }, "", out var __result))
if (_engine.TryHandleCallWithReturn<string, string>(0, "GetValue", key, "", out var __result))
{
return __result;
}
Expand Down
6 changes: 3 additions & 3 deletions ...erator.Tests/Snapshots/Partial_Mock_With_Generic_Constrained_Virtual_Methods.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ namespace TUnit.Mocks.Generated

public override T GetById<T>(int id)
{
if (_engine.TryHandleCallWithReturn<T>(0, "GetById", new object?[] { id }, default!, out var __result))
if (_engine.TryHandleCallWithReturn<T, int>(0, "GetById", id, default!, out var __result))
{
return __result;
}
Expand All @@ -26,7 +26,7 @@ namespace TUnit.Mocks.Generated

public override void Save<T>(T entity)
{
if (_engine.TryHandleCall(1, "Save", new object?[] { entity }))
if (_engine.TryHandleCall<T>(1, "Save", entity))
{
return;
}
Expand All @@ -35,7 +35,7 @@ namespace TUnit.Mocks.Generated

public override TResult Transform<TInput, TResult>(TInput input)
{
if (_engine.TryHandleCallWithReturn<TResult>(2, "Transform", new object?[] { input }, default, out var __result))
if (_engine.TryHandleCallWithReturn<TResult, TInput>(2, "Transform", input, default, out var __result))
{
return __result;
}
Expand Down
2 changes: 1 addition & 1 deletion TUnit.Mocks.SourceGenerator.Tests/Snapshots/Simple_Interface_With_One_Method.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ namespace TUnit.Mocks.Generated

public string Greet(string name)
{
return _engine.HandleCallWithReturn<string>(0, "Greet", new object?[] { name }, "");
return _engine.HandleCallWithReturn<string, string>(0, "Greet", name, "");
}

[global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
Expand Down
2 changes: 1 addition & 1 deletion ...s.SourceGenerator.Tests/Snapshots/Static_Extension_Discovery_Without_Mock_Of.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ namespace TUnit.Mocks.Generated

public void Notify(string message)
{
_engine.HandleCall(0, "Notify", new object?[] { message });
_engine.HandleCall<string>(0, "Notify", message);
}

public string GetStatus()
Expand Down
4 changes: 2 additions & 2 deletions ...Generator.Tests/Snapshots/Wrap_Mock_With_Generic_Constrained_Virtual_Methods.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ namespace TUnit.Mocks.Generated

public override T Get<T>(int id)
{
if (_engine.TryHandleCallWithReturn<T>(0, "Get", new object?[] { id }, default!, out var __result))
if (_engine.TryHandleCallWithReturn<T, int>(0, "Get", id, default!, out var __result))
{
return __result;
}
Expand All @@ -28,7 +28,7 @@ namespace TUnit.Mocks.Generated

public override void Store<T>(T item)
{
if (_engine.TryHandleCall(1, "Store", new object?[] { item }))
if (_engine.TryHandleCall<T>(1, "Store", item))
{
return;
}
Expand Down
Loading
Loading