Skip to content

fix: resolve build warnings in solution #5386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 3 commits into from
Apr 4, 2026
+24 −5
Merged

fix: resolve build warnings in solution #5386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
05fd406
fix: resolve all build warnings in solution
thomhurst Apr 4, 2026
90a3209
chore: scope NU1504 suppression to F# projects only
thomhurst Apr 4, 2026
17d4634
fix: remove trailing tabs from F# template snapshot files
thomhurst Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions TUnit.Assertions.SourceGenerator.Tests/TUnit.Assertions.SourceGenerator.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

<Import Project="..\TestProject.props" />

<PropertyGroup>
<!-- Source generator projects (netstandard2.0) bring in older Microsoft.Bcl.AsyncInterfaces -->
<NoWarn>$(NoWarn);MSB3277</NoWarn>
</PropertyGroup>

<ItemGroup>
<ProjectReference Include="..\TUnit.Assertions.SourceGenerator\TUnit.Assertions.SourceGenerator.csproj" />
<ProjectReference Include="..\TUnit.Assertions\TUnit.Assertions.csproj" />
Expand Down
5 changes: 5 additions & 0 deletions TUnit.Core.SourceGenerator.Tests/TUnit.Core.SourceGenerator.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

<Import Project="..\TestProject.props" />

<PropertyGroup>
<!-- Source generator projects (netstandard2.0) bring in older Microsoft.Bcl.AsyncInterfaces -->
<NoWarn>$(NoWarn);MSB3277</NoWarn>
</PropertyGroup>

<ItemGroup>
<ProjectReference Include="..\TUnit.Core.SourceGenerator\TUnit.Core.SourceGenerator.csproj" />
<ProjectReference Include="..\TUnit.Core\TUnit.Core.csproj" />
Expand Down
1 change: 1 addition & 0 deletions TUnit.SourceGenerator.Benchmarks/TUnit.SourceGenerator.Benchmarks.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<EmitCompilerGeneratedFiles>true</EmitCompilerGeneratedFiles>
<NoWarn>$(NoWarn);NU1701</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 2 additions & 0 deletions TUnit.SourceGenerator.IncrementalTests/TUnit.SourceGenerator.IncrementalTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
<!-- Source generator projects (netstandard2.0) bring in older Microsoft.Bcl.AsyncInterfaces -->
<NoWarn>$(NoWarn);MSB3277</NoWarn>
<RootNamespace>TUnit.Assertions.SourceGenerator.IncrementalTests</RootNamespace>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion ...pNet.FSharp._.verified/TUnit.AspNet.FSharp/TUnit.AspNet.FSharp/TUnit.AspNet.FSharp.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="0.0.0-scrubbed" />
<PackageReference Include="TUnit" Version="0.0.0-scrubbed" />
<PackageReference Include="TUnit.Assertions.FSharp" Version="0.0.0-scrubbed" />
<PackageReference Include="TUnit.Assertions.FSharp" Version="0.0.0-scrubbed" />
</ItemGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion ...hots/InstantiationTestWithFSharp.TUnit.FSharp._.verified/TUnit.FSharp/TUnit.FSharp.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<ItemGroup>
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="0.0.0-scrubbed" />
<PackageReference Include="TUnit" Version="0.0.0-scrubbed" />
<PackageReference Include="TUnit.Assertions.FSharp" Version="0.0.0-scrubbed" />
<PackageReference Include="TUnit.Assertions.FSharp" Version="0.0.0-scrubbed" />
</ItemGroup>

<ItemGroup>
Expand Down
6 changes: 6 additions & 0 deletions TUnit.Templates/content/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
<?xml version="1.0" encoding="utf-8"?>
<Project>
<PropertyGroup Condition="'$(MSBuildProjectExtension)' == '.fsproj'">
<!-- TUnit.Assertions.props auto-adds TUnit.Assertions.FSharp for F# projects;
template fsproj files also include it explicitly with a pinned version -->
<NoWarn>$(NoWarn);NU1504</NoWarn>
</PropertyGroup>

<ItemGroup Condition="$(MSBuildProjectName.Contains('TestProject'))">
<Using Include="TUnit.Core.HookType" Static="True" />
<Using Include="TUnit.Core" />
Expand Down
2 changes: 1 addition & 1 deletion TUnit.Templates/content/TUnit.AspNet.FSharp/TestProject/TestProject.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="10.0.5" />
<PackageReference Include="TUnit" Version="1.25.0" />
<PackageReference Include="TUnit.Assertions.FSharp" Version="1.25.0" />
<PackageReference Include="TUnit.Assertions.FSharp" Version="1.25.0" />
</ItemGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion TUnit.Templates/content/TUnit.FSharp/TestProject.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<ItemGroup>
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="10.0.5" />
<PackageReference Include="TUnit" Version="1.25.0" />
<PackageReference Include="TUnit.Assertions.FSharp" Version="1.25.0" />
<PackageReference Include="TUnit.Assertions.FSharp" Version="1.25.0" />
</ItemGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion TUnit.TestProject.Library/TUnit.TestProject.Library.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<Import Project="..\TestLibrary.props" />

<PropertyGroup>
<TargetFrameworks>net6.0;net8.0;net9.0;net10.0;net472;netstandard2.0</TargetFrameworks>
<TargetFrameworks>net8.0;net9.0;net10.0;net472;netstandard2.0</TargetFrameworks>
</PropertyGroup>

<Import Project="..\TestLibrary.targets" />
Expand Down
Loading