Skip to content

fix: resolve race condition in HookExecutionOrderTests #5355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 3 commits into from
Apr 3, 2026
Merged

fix: resolve race condition in HookExecutionOrderTests #5355

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d678a3e
fix: resolve race condition in HookExecutionOrderTests
thomhurst Apr 3, 2026
2931368
add [NotInParallel] to HookExecutionOrderTests
thomhurst Apr 3, 2026
cfb2fa8
refactor: use per-test StateBag instead of shared static state
thomhurst Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions TUnit.Engine.Tests/HookExecutionOrderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,30 +8,35 @@ public sealed class GlobalHookExecutionOrderSetup
[BeforeEvery(Test)]
public static void GlobalSetup(TestContext context)
{
HookExecutionOrderTests._executionOrder.Clear(); // Clear before each test
HookExecutionOrderTests._executionOrder.Add("BeforeEvery");
if (context.Metadata.TestDetails.ClassType != typeof(HookExecutionOrderTests))
{
return;
}

var order = context.StateBag.GetOrAdd<List<string>>("executionOrder", _ => []);
order.Add("BeforeEvery");
}
}

public class HookExecutionOrderTests
{
internal static readonly List<string> _executionOrder = [];

[Before(Test)]
public void InstanceSetup()
{
_executionOrder.Add("Before");
var order = TestContext.Current!.StateBag.GetOrAdd<List<string>>("executionOrder", _ => []);
order.Add("Before");
}

[Test]
public void VerifyExecutionOrder()
{
_executionOrder.Add("Test");
var order = TestContext.Current!.StateBag.GetOrAdd<List<string>>("executionOrder", _ => []);
order.Add("Test");

// Verify that BeforeEvery runs before Before
_executionOrder.Count.ShouldBe(3);
_executionOrder[0].ShouldBe("BeforeEvery");
_executionOrder[1].ShouldBe("Before");
_executionOrder[2].ShouldBe("Test");
order.Count.ShouldBe(3);
order[0].ShouldBe("BeforeEvery");
order[1].ShouldBe("Before");
order[2].ShouldBe("Test");
}
}
Loading