Conversation
There was a problem hiding this comment.
Dependency Update Review: Verify 31.13.5 → 31.14.0
This is a straightforward Renovate Bot minor version bump for the Verify snapshot testing packages. The change is a 3-line diff in Directory.Packages.props only. Overall this looks correct, but there are a couple of observations worth noting.
What changes in 31.14.0
The release notes for this version highlight:
- #1700 — [TUnit] infrastructure fixtures appear in verified filenames / adds
VerifierSettings.IgnoreParameters<T> - #1701 — Support global
IgnoreParameterssetting - #1702 — Add
IgnoreClassArguments
Issue #1700 is directly relevant to TUnit: it specifically fixes a problem where TUnit infrastructure fixtures (e.g. [Before(TestDiscovery)] hooks, assembly-level fixtures) were leaking into Verify's verified filenames, causing spurious snapshot mismatches. This is a welcome fix for the TUnit ecosystem.
Observation: Verify.NUnit is declared but never used
Verify.NUnit is present in Directory.Packages.props as a centrally-managed version, but no .csproj in the repository contains a <PackageReference Include="Verify.NUnit" /> entry. The only places that reference Verify packages are:
TUnit.Core.SourceGenerator.Tests— usesVerify+Verify.TUnitTUnit.Mocks.SourceGenerator.Tests— usesVerify+Verify.TUnitTUnit.Assertions.SourceGenerator.Tests— usesVerify+Verify.TUnitTUnit.PublicAPI— usesVerify+Verify.TUnit
Keeping an unused PackageVersion entry in Directory.Packages.props is harmless (it only pins a version without pulling a transitive reference), but it does create a small maintenance burden: future Renovate PRs will continue to bump a package that no project actually consumes. If Verify.NUnit was removed at some point as a direct dependency and never replaced with a PackageReference, the corresponding PackageVersion line could be cleaned up. That said, this is pre-existing and not introduced by this PR.
Snapshot test consideration
Because 31.14.0 changes how Verify resolves filenames when TUnit infrastructure fixtures are involved (issue #1700), there is a theoretical risk of verified filename format changes that could break existing .verified.txt snapshot files. In practice the fix is on the Verify side and should only affect scenarios where infrastructure fixture class names were previously bleeding into filenames — but it is worth confirming the CI snapshot tests pass green after merging, specifically for the source generator test projects.
Summary
The update is safe and beneficial. The Verify.NUnit unused entry is a pre-existing cosmetic issue worth cleaning up separately if desired. No snapshot file updates appear to be needed from this diff alone, but verifying the CI run is the right validation step.
There was a problem hiding this comment.
Dependency Update Review: Verify 31.13.5 to 31.14.0
This is a straightforward Renovate Bot minor version bump. The change is a 3-line diff in Directory.Packages.props only.
What changes in 31.14.0
The release notes highlight three items:
- Issue 1700 - [TUnit] infrastructure fixtures appear in verified filenames / adds VerifierSettings.IgnoreParameters
- PR 1701 - Support global IgnoreParameters setting
- PR 1702 - Add IgnoreClassArguments
Issue 1700 is directly relevant to TUnit: it fixes a problem where TUnit infrastructure fixtures (e.g. [Before(TestDiscovery)] hooks, assembly-level fixtures) were leaking into Verify verified filenames, causing spurious snapshot mismatches. This is a welcome fix for the ecosystem.
Observation: Verify.NUnit is declared but never used
Verify.NUnit is present in Directory.Packages.props as a centrally-managed version, but no .csproj in the repository contains a PackageReference for it. The four projects that use Verify packages (TUnit.Core.SourceGenerator.Tests, TUnit.Mocks.SourceGenerator.Tests, TUnit.Assertions.SourceGenerator.Tests, TUnit.PublicAPI) all reference only Verify and Verify.TUnit.
Keeping an unused PackageVersion entry is harmless in terms of build output, but it does create ongoing maintenance noise: Renovate will continue to file PRs bumping a version that no project actually consumes. This is pre-existing and not introduced by this PR, but it is a good candidate for a follow-up cleanup if Verify.NUnit was removed as a direct dependency at some point and the PackageVersion entry was never pruned.
Snapshot test consideration
Because 31.14.0 changes how Verify resolves filenames when TUnit infrastructure fixtures are involved, there is a theoretical risk of verified filename format changes that could affect existing .verified.txt files. The fix should only impact scenarios where infrastructure fixture class names were previously bleeding into filenames. Confirming CI snapshot tests pass green is the right validation.
Summary
The update is safe and beneficial. No issues with the diff itself. The Verify.NUnit unused entry is worth a follow-up cleanup but is out of scope for this PR.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
Updated [TUnit](https://github.com/thomhurst/TUnit) from 1.23.7 to 1.24.13. <details> <summary>Release notes</summary> _Sourced from [TUnit's releases](https://github.com/thomhurst/TUnit/releases)._ ## 1.24.13 <!-- Release notes generated using configuration in .github/release.yml at v1.24.13 --> ## What's Changed ### Other Changes * perf(mocks): optimize MockEngine for lower allocation and faster verification by @thomhurst in thomhurst/TUnit#5319 * Remove defunct `UseTestingPlatformProtocol` reference for vscode by @erwinkramer in thomhurst/TUnit#5328 * perf(aspnetcore): prevent thread pool starvation during parallel WebApplicationTest server init by @thomhurst in thomhurst/TUnit#5329 * fix TUnit0073 for when type from from another assembly by @SimonCropp in thomhurst/TUnit#5322 * Fix implicit conversion operators bypassed in property injection casts by @Copilot in thomhurst/TUnit#5317 * fix(mocks): skip non-virtual 'new' methods when discovering mockable members by @thomhurst in thomhurst/TUnit#5330 * feat(mocks): IFoo.Mock() discovery with generic fallback and ORP resolution by @thomhurst in thomhurst/TUnit#5327 ### Dependencies * chore(deps): update tunit to 1.24.0 by @thomhurst in thomhurst/TUnit#5315 * chore(deps): update aspire to 13.2.1 by @thomhurst in thomhurst/TUnit#5323 * chore(deps): update verify to 31.14.0 by @thomhurst in thomhurst/TUnit#5325 ## New Contributors * @erwinkramer made their first contribution in thomhurst/TUnit#5328 **Full Changelog**: thomhurst/TUnit@v1.24.0...v1.24.13 ## 1.24.0 <!-- Release notes generated using configuration in .github/release.yml at v1.24.0 --> ## What's Changed ### Other Changes * perf: optimize TUnit.Mocks hot paths by @thomhurst in thomhurst/TUnit#5304 * fix: resolve System.Memory version conflict on .NET Framework (net462) by @thomhurst in thomhurst/TUnit#5303 * fix: resolve CS0460/CS0122/CS0115 when mocking concrete classes from external assemblies by @thomhurst in thomhurst/TUnit#5310 * feat(mocks): parameterless Returns() and ReturnsAsync() for async methods by @thomhurst in thomhurst/TUnit#5309 * Fix typo in NUnit manual migration guide by @aa-ko in thomhurst/TUnit#5312 * refactor(mocks): unify Mock.Of<T>() and Mock.OfPartial<T>() into single API by @thomhurst in thomhurst/TUnit#5311 * refactor(mocks): clean up Mock API surface by @thomhurst in thomhurst/TUnit#5314 * refactor(mocks): remove generic/untyped overloads from public API by @thomhurst in thomhurst/TUnit#5313 ### Dependencies * chore(deps): update tunit to 1.23.7 by @thomhurst in thomhurst/TUnit#5305 * chore(deps): update dependency mockolate to 2.1.1 by @thomhurst in thomhurst/TUnit#5307 ## New Contributors * @aa-ko made their first contribution in thomhurst/TUnit#5312 **Full Changelog**: thomhurst/TUnit@v1.23.7...v1.24.0 Commits viewable in [compare view](thomhurst/TUnit@v1.23.7...v1.24.13). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This PR contains the following updates:
31.13.5→31.14.031.13.5→31.14.031.13.5→31.14.0Release Notes
VerifyTests/Verify (Verify)
v31.14.0Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Renovate Bot.