Skip to content

fix: respect user-set TUnitImplicitUsings from Directory.Build.props #5280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 7 commits into from
Mar 29, 2026
+3 −35
Merged

fix: respect user-set TUnitImplicitUsings from Directory.Build.props #5280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a0c7ca9
fix: prevent TUnit props from flowing to transitive consumers (#5277)
thomhurst Mar 28, 2026
f16a2cb
refactor: deduplicate Polyfill logic per review feedback
thomhurst Mar 28, 2026
a9deb75
fix: restore Polyfill logic to build/ files for direct consumers
thomhurst Mar 28, 2026
bdeaf2e
fix: use build/-only approach (remove buildTransitive entirely)
thomhurst Mar 28, 2026
13bee15
fix: restore buildTransitive for TUnit.Engine to preserve test framew…
thomhurst Mar 29, 2026
d52deb5
fix: restore buildTransitive for TUnit.Core and TUnit.Assertions
thomhurst Mar 29, 2026
5e2b230
fix: remove dead xunit detection from props files
thomhurst Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions TUnit.Assertions/TUnit.Assertions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<Project>

<PropertyGroup>
<XunitPackageReferenceFound>false</XunitPackageReferenceFound>
</PropertyGroup>

<Target Name="SetXunitPackageReferenceFound" BeforeTargets="PrepareForBuild">
<!-- Filter PackageReference for xunit and xunit.v3 -->
<ItemGroup>
<_XunitReference Include="@(PackageReference)"
Condition="'%(PackageReference.Identity)' == 'xunit' Or '%(PackageReference.Identity)' == 'xunit.v3'" />
</ItemGroup>
<PropertyGroup>
<XunitPackageReferenceFound Condition="'@(_XunitReference)' != ''">true</XunitPackageReferenceFound>
</PropertyGroup>
</Target>

<PropertyGroup Condition="'$(XunitPackageReferenceFound)' == 'false' And '$(TUnitAssertionsImplicitUsings)' == ''">
<PropertyGroup Condition="'$(TUnitAssertionsImplicitUsings)' == ''">
<TUnitAssertionsImplicitUsings>true</TUnitAssertionsImplicitUsings>
</PropertyGroup>

Expand Down
19 changes: 1 addition & 18 deletions TUnit.Core/TUnit.Core.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<Project>

<PropertyGroup>
<XunitPackageReferenceFound>false</XunitPackageReferenceFound>
</PropertyGroup>

<Target Name="SetXunitPackageReferenceFound" BeforeTargets="PrepareForBuild">
<!-- Filter PackageReference for xunit and xunit.v3 -->
<ItemGroup>
<_XunitReference Include="@(PackageReference)"
Condition="'%(PackageReference.Identity)' == 'xunit' Or '%(PackageReference.Identity)' == 'xunit.v3'" />
</ItemGroup>
<PropertyGroup>
<XunitPackageReferenceFound Condition="'@(_XunitReference)' != ''">true</XunitPackageReferenceFound>
</PropertyGroup>
</Target>

<PropertyGroup Condition="'$(XunitPackageReferenceFound)' == 'false'">
<PropertyGroup Condition="'$(TUnitImplicitUsings)' == ''">
<TUnitImplicitUsings>true</TUnitImplicitUsings>
</PropertyGroup>

Expand All @@ -34,9 +19,7 @@
</Target>

<PropertyGroup>
<!-- Default to enabling polyfills for older frameworks -->
<EnableTUnitPolyfills Condition="'$(EnableTUnitPolyfills)' == '' and ('$(TargetFramework)' == 'netstandard2.0' or '$(TargetFramework)' == 'netstandard2.1' or '$(TargetFrameworkIdentifier)' == '.NETFramework')">true</EnableTUnitPolyfills>
<!-- Use embedded Polyfill attributes to prevent type conflicts across projects -->
<PolyUseEmbeddedAttribute Condition="'$(PolyUseEmbeddedAttribute)' == ''">true</PolyUseEmbeddedAttribute>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion TUnit.Core/TUnit.Core.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<?xml version="1.0" encoding="utf-8"?>
<Project>

<ItemGroup Condition="'$(TUnitImplicitUsings)' == 'true'">
Expand Down
Loading