Fix ConfigureTestConfiguration being invoked twice

TUnit.AspNetCore/TestWebApplicationFactory.cs

@@ -21,15 +21,13 @@ public WebApplicationFactory<TEntryPoint> GetIsolatedFactory(
         TestContext testContext,
         WebApplicationTestOptions options,
         Action<IServiceCollection> configureIsolatedServices,
-        Action<IConfigurationBuilder> configureIsolatedStartupConfiguration,
         Action<WebHostBuilderContext, IConfigurationBuilder> configureIsolatedAppConfiguration,
         Action<IWebHostBuilder>? configureWebHostBuilder = null)
     {
         return WithWebHostBuilder(builder =>
         {
             var configurationBuilder = new ConfigurationManager();
             ConfigureStartupConfiguration(configurationBuilder);
-            configureIsolatedStartupConfiguration(configurationBuilder);
 
             foreach (var keyValuePair in configurationBuilder.AsEnumerable())
             {

TUnit.AspNetCore/WebApplicationTest.cs

@@ -115,7 +115,6 @@ public async Task InitializeFactoryAsync(TestContext testContext)
                 testContext,
                 _options,
                 ConfigureTestServices,
-                ConfigureTestConfiguration,
                 (_, config) => ConfigureTestConfiguration(config),
                 ConfigureWebHostBuilder));
 

TUnit.Example.Asp.Net.TestProject/FactoryMethodOrderTests.cs

@@ -10,7 +10,7 @@ namespace TUnit.Example.Asp.Net.TestProject;
 ///
 /// This allows:
 /// - Factory to provide base configuration shared across tests
-/// - Tests to override factory defaults via ConfigureTestConfiguration (order 5)
+/// - Tests to override factory defaults via ConfigureTestConfiguration (order 6)
 /// </summary>
 public class FactoryMethodOrderTests : TestsBase
 {
@@ -105,16 +105,16 @@ await Assert.That(ConfigureTestServicesCalledOrder)
     }
 
     [Test]
-    [DisplayName("Complete relative execution order: Options → Setup → Config → WebHost → Services → Startup")]
+    [DisplayName("Complete relative execution order: Options → Setup → WebHost → Config → Services → Startup")]
     public async Task Full_Relative_Order()
     {
         _ = Factory.CreateClient();
 
         // Verify all hooks were called
         await Assert.That(ConfigureTestOptionsCalledOrder).IsGreaterThan(0);
         await Assert.That(SetupCalledOrder).IsGreaterThan(0);
-        await Assert.That(ConfigureTestConfigurationCalledOrder).IsGreaterThan(0);
         await Assert.That(ConfigureWebHostBuilderCalledOrder).IsGreaterThan(0);
+        await Assert.That(ConfigureTestConfigurationCalledOrder).IsGreaterThan(0);
         await Assert.That(ConfigureTestServicesCalledOrder).IsGreaterThan(0);
         await Assert.That(StartupCalledOrder).IsGreaterThan(0);
 
@@ -124,16 +124,16 @@ await Assert.That(ConfigureTestOptionsCalledOrder)
             .Because("ConfigureTestOptions runs before SetupAsync");
 
         await Assert.That(SetupCalledOrder)
-            .IsLessThan(ConfigureTestConfigurationCalledOrder)
-            .Because("SetupAsync runs before ConfigureTestConfiguration");
-
-        await Assert.That(ConfigureTestConfigurationCalledOrder)
             .IsLessThan(ConfigureWebHostBuilderCalledOrder)
-            .Because("ConfigureTestConfiguration runs before ConfigureWebHostBuilder");
+            .Because("SetupAsync runs before ConfigureWebHostBuilder");
 
         await Assert.That(ConfigureWebHostBuilderCalledOrder)
+            .IsLessThan(ConfigureTestConfigurationCalledOrder)
+            .Because("ConfigureWebHostBuilder runs before ConfigureTestConfiguration");
+
+        await Assert.That(ConfigureTestConfigurationCalledOrder)
             .IsLessThan(ConfigureTestServicesCalledOrder)
-            .Because("ConfigureWebHostBuilder runs before ConfigureTestServices");
+            .Because("ConfigureTestConfiguration runs before ConfigureTestServices");
 
         await Assert.That(ConfigureTestServicesCalledOrder)
             .IsLessThan(StartupCalledOrder)

TUnit.Example.Asp.Net.TestProject/TestsBase.cs

@@ -67,13 +67,8 @@ protected override void ConfigureTestServices(IServiceCollection services)
 
     protected override void ConfigureTestConfiguration(IConfigurationBuilder config)
     {
-        // Track first call only (this method is called twice - once for startup config, once for app config)
-        if (ConfigureTestConfigurationCalledOrder == 0)
-        {
-            ConfigureTestConfigurationCalledOrder = GetNextOrder();
-            ConfigureTestConfigurationCalledAt = DateTime.UtcNow;
-        }
-
+        ConfigureTestConfigurationCalledOrder = GetNextOrder();
+        ConfigureTestConfigurationCalledAt = DateTime.UtcNow;
         base.ConfigureTestConfiguration(config);
     }
 

docs/docs/examples/aspnet.md

@@ -124,8 +124,8 @@ Understanding the execution order is critical for writing correct tests. Here's
 │  3. Factory.ConfigureWebHost    Base factory configuration      │
 │  4. Factory.ConfigureStartup... Base factory startup config     │
 │  ───────────────────────────────────────────────────────────    │
-│  5. ConfigureTestConfiguration  Test config (overrides factory) │
-│  6. ConfigureWebHostBuilder     Escape hatch (low-level access) │
+│  5. ConfigureWebHostBuilder     Escape hatch (low-level access) │
+│  6. ConfigureTestConfiguration  Test config (overrides factory) │
 │  7. ConfigureTestServices       Test services (overrides)       │
 │  ───────────────────────────────────────────────────────────    │
 │  8. Application Startup         Server starts                   │
@@ -143,8 +143,8 @@ Understanding the execution order is critical for writing correct tests. Here's
 | `SetupAsync` | Per-test | Async operations before config (create DB tables) |
 | `Factory.ConfigureWebHost` | Shared | Base configuration for all tests |
 | `Factory.ConfigureStartupConfiguration` | Shared | Base startup configuration |
-| `ConfigureTestConfiguration` | Per-test | Override factory configuration |
 | `ConfigureWebHostBuilder` | Per-test | Low-level escape hatch |
+| `ConfigureTestConfiguration` | Per-test | Override factory configuration |
 | `ConfigureTestServices` | Per-test | Override factory services |
 
 :::tip Tests Can Override Factory
@@ -790,7 +790,7 @@ The key benefits:
 
 **Problem:** You set a value in `ConfigureTestConfiguration` but the factory's value is still used.
 
-**Solution:** Make sure you're using the same configuration key. The test configuration runs **after** the factory configuration (step 5 vs steps 3-4), so it should override. Check that:
+**Solution:** Make sure you're using the same configuration key. The test configuration runs **after** the factory configuration (step 6 vs steps 3-4), so it should override. Check that:
 
 1. You're using `AddInMemoryCollection` which adds to the config sources
 2. The configuration key path is exactly the same
@@ -927,14 +927,14 @@ public class LifecycleDebugTest : WebApplicationTest<WebApplicationFactory, Prog
         await base.SetupAsync();
     }
 
-    protected override void ConfigureTestConfiguration(IConfigurationBuilder config)
+    protected override void ConfigureWebHostBuilder(IWebHostBuilder builder)
     {
-        Console.WriteLine("5. ConfigureTestConfiguration");
+        Console.WriteLine("5. ConfigureWebHostBuilder");
     }
 
-    protected override void ConfigureWebHostBuilder(IWebHostBuilder builder)
+    protected override void ConfigureTestConfiguration(IConfigurationBuilder config)
     {
-        Console.WriteLine("6. ConfigureWebHostBuilder");
+        Console.WriteLine("6. ConfigureTestConfiguration");
     }
 
     protected override void ConfigureTestServices(IServiceCollection services)