Skip to content

Fix inverted colors in HTML report ring chart due to locale-dependent decimal formatting #5185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 4 commits into from
Mar 18, 2026
Merged

Fix inverted colors in HTML report ring chart due to locale-dependent decimal formatting #5185

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6fdd664
Initial plan
Copilot Mar 18, 2026
7481c82
Fix inverted colors in HTML report ring chart by using positive strok…
Copilot Mar 18, 2026
007ad90
Fix locale-dependent decimal formatting in SVG ring chart causing inv…
Copilot Mar 18, 2026
dc25963
Fix netstandard2.0 build: replace string.Create with ToString in Form…
Copilot Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
using System.Globalization;
using System.Net;
using System.Text;
using System.Text.Json;
Expand Down Expand Up @@ -220,7 +221,7 @@

sb.AppendLine("</svg>");
sb.Append("<div class=\"ring-center\"><span class=\"ring-pct\">");
sb.Append(passRate.ToString("F0"));
sb.Append(passRate.ToString("F0", CultureInfo.InvariantCulture));
sb.Append("<small>%</small></span><span class=\"ring-lbl\">");
sb.Append(summary.Total > 0 ? "pass rate" : "no tests");
sb.AppendLine("</span></div>");
Expand Down Expand Up @@ -252,11 +253,11 @@
sb.Append("<circle class=\"ring-seg\" cx=\"60\" cy=\"60\" r=\"54\" fill=\"none\" stroke=\"");
sb.Append(color);
sb.Append("\" stroke-width=\"10\" stroke-linecap=\"round\" stroke-dasharray=\"");
sb.Append(len.ToString("F2"));
sb.Append(len.ToString("F2", CultureInfo.InvariantCulture));
sb.Append(' ');
sb.Append((circumference - len).ToString("F2"));
sb.Append((circumference - len).ToString("F2", CultureInfo.InvariantCulture));
sb.Append("\" stroke-dashoffset=\"-");
sb.Append(offset.ToString("F2"));
sb.Append(offset.ToString("F2", CultureInfo.InvariantCulture));
sb.AppendLine("\" transform=\"rotate(-90 60 60)\"/>");
}

Expand Down Expand Up @@ -368,15 +369,15 @@
// Show milliseconds for anything under 1 second (avoids rounding 999ms to "1.00s")
if (Math.Round(ms) < 1000)
{
return $"{ms:F0}ms";
return string.Create(CultureInfo.InvariantCulture, $"{ms:F0}ms");

Check failure on line 372 in TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs

View workflow job for this annotation

GitHub Actions / modularpipeline (fr-FR) 

Parmi les arguments spécifiés, aucun ne correspond au paramètre obligatoire 'action' de 'Polyfill.extension(string).Create<TState>(int, TState, SpanAction<char, TState>)'

Check failure on line 372 in TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs

View workflow job for this annotation

GitHub Actions / modularpipeline (fr-FR) 

Parmi les arguments spécifiés, aucun ne correspond au paramètre obligatoire 'action' de 'Polyfill.extension(string).Create<TState>(int, TState, SpanAction<char, TState>)'

Check failure on line 372 in TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs

View workflow job for this annotation

GitHub Actions / modularpipeline (de-DE) 

Es wurde kein Argument angegeben, das dem erforderlichen Parameter "action" von "Polyfill.extension(string).Create<TState>(int, TState, SpanAction<char, TState>)" entspricht.

Check failure on line 372 in TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs

View workflow job for this annotation

GitHub Actions / modularpipeline (de-DE) 

Es wurde kein Argument angegeben, das dem erforderlichen Parameter "action" von "Polyfill.extension(string).Create<TState>(int, TState, SpanAction<char, TState>)" entspricht.

Check failure on line 372 in TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs

View workflow job for this annotation

GitHub Actions / modularpipeline (macos-latest) 

There is no argument given that corresponds to the required parameter 'action' of 'Polyfill.extension(string).Create<TState>(int, TState, SpanAction<char, TState>)'

Check failure on line 372 in TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs

View workflow job for this annotation

GitHub Actions / modularpipeline (macos-latest) 

There is no argument given that corresponds to the required parameter 'action' of 'Polyfill.extension(string).Create<TState>(int, TState, SpanAction<char, TState>)'

Check failure on line 372 in TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs

View workflow job for this annotation

GitHub Actions / modularpipeline (windows-latest) 

There is no argument given that corresponds to the required parameter 'action' of 'Polyfill.extension(string).Create<TState>(int, TState, SpanAction<char, TState>)'

Check failure on line 372 in TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs

View workflow job for this annotation

GitHub Actions / modularpipeline (windows-latest) 

There is no argument given that corresponds to the required parameter 'action' of 'Polyfill.extension(string).Create<TState>(int, TState, SpanAction<char, TState>)'

Check failure on line 372 in TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs

View workflow job for this annotation

GitHub Actions / modularpipeline (ubuntu-latest) 

There is no argument given that corresponds to the required parameter 'action' of 'Polyfill.extension(string).Create<TState>(int, TState, SpanAction<char, TState>)'

Check failure on line 372 in TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs

View workflow job for this annotation

GitHub Actions / modularpipeline (ubuntu-latest) 

There is no argument given that corresponds to the required parameter 'action' of 'Polyfill.extension(string).Create<TState>(int, TState, SpanAction<char, TState>)'
}

if (ms < 60000)
{
return $"{ms / 1000:F2}s";
return string.Create(CultureInfo.InvariantCulture, $"{ms / 1000:F2}s");

Check failure on line 377 in TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs

View workflow job for this annotation

GitHub Actions / modularpipeline (fr-FR) 

Parmi les arguments spécifiés, aucun ne correspond au paramètre obligatoire 'action' de 'Polyfill.extension(string).Create<TState>(int, TState, SpanAction<char, TState>)'

Check failure on line 377 in TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs

View workflow job for this annotation

GitHub Actions / modularpipeline (fr-FR) 

Parmi les arguments spécifiés, aucun ne correspond au paramètre obligatoire 'action' de 'Polyfill.extension(string).Create<TState>(int, TState, SpanAction<char, TState>)'

Check failure on line 377 in TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs

View workflow job for this annotation

GitHub Actions / modularpipeline (de-DE) 

Es wurde kein Argument angegeben, das dem erforderlichen Parameter "action" von "Polyfill.extension(string).Create<TState>(int, TState, SpanAction<char, TState>)" entspricht.

Check failure on line 377 in TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs

View workflow job for this annotation

GitHub Actions / modularpipeline (de-DE) 

Es wurde kein Argument angegeben, das dem erforderlichen Parameter "action" von "Polyfill.extension(string).Create<TState>(int, TState, SpanAction<char, TState>)" entspricht.

Check failure on line 377 in TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs

View workflow job for this annotation

GitHub Actions / modularpipeline (macos-latest) 

There is no argument given that corresponds to the required parameter 'action' of 'Polyfill.extension(string).Create<TState>(int, TState, SpanAction<char, TState>)'

Check failure on line 377 in TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs

View workflow job for this annotation

GitHub Actions / modularpipeline (macos-latest) 

There is no argument given that corresponds to the required parameter 'action' of 'Polyfill.extension(string).Create<TState>(int, TState, SpanAction<char, TState>)'

Check failure on line 377 in TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs

View workflow job for this annotation

GitHub Actions / modularpipeline (windows-latest) 

There is no argument given that corresponds to the required parameter 'action' of 'Polyfill.extension(string).Create<TState>(int, TState, SpanAction<char, TState>)'

Check failure on line 377 in TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs

View workflow job for this annotation

GitHub Actions / modularpipeline (windows-latest) 

There is no argument given that corresponds to the required parameter 'action' of 'Polyfill.extension(string).Create<TState>(int, TState, SpanAction<char, TState>)'

Check failure on line 377 in TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs

View workflow job for this annotation

GitHub Actions / modularpipeline (ubuntu-latest) 

There is no argument given that corresponds to the required parameter 'action' of 'Polyfill.extension(string).Create<TState>(int, TState, SpanAction<char, TState>)'

Check failure on line 377 in TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs

View workflow job for this annotation

GitHub Actions / modularpipeline (ubuntu-latest) 

There is no argument given that corresponds to the required parameter 'action' of 'Polyfill.extension(string).Create<TState>(int, TState, SpanAction<char, TState>)'
}

return $"{ms / 60000:F1}m";
return string.Create(CultureInfo.InvariantCulture, $"{ms / 60000:F1}m");

Check failure on line 380 in TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs

View workflow job for this annotation

GitHub Actions / modularpipeline (fr-FR) 

Parmi les arguments spécifiés, aucun ne correspond au paramètre obligatoire 'action' de 'Polyfill.extension(string).Create<TState>(int, TState, SpanAction<char, TState>)'

Check failure on line 380 in TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs

View workflow job for this annotation

GitHub Actions / modularpipeline (fr-FR) 

Parmi les arguments spécifiés, aucun ne correspond au paramètre obligatoire 'action' de 'Polyfill.extension(string).Create<TState>(int, TState, SpanAction<char, TState>)'

Check failure on line 380 in TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs

View workflow job for this annotation

GitHub Actions / modularpipeline (de-DE) 

Es wurde kein Argument angegeben, das dem erforderlichen Parameter "action" von "Polyfill.extension(string).Create<TState>(int, TState, SpanAction<char, TState>)" entspricht.

Check failure on line 380 in TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs

View workflow job for this annotation

GitHub Actions / modularpipeline (de-DE) 

Es wurde kein Argument angegeben, das dem erforderlichen Parameter "action" von "Polyfill.extension(string).Create<TState>(int, TState, SpanAction<char, TState>)" entspricht.

Check failure on line 380 in TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs

View workflow job for this annotation

GitHub Actions / modularpipeline (macos-latest) 

There is no argument given that corresponds to the required parameter 'action' of 'Polyfill.extension(string).Create<TState>(int, TState, SpanAction<char, TState>)'

Check failure on line 380 in TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs

View workflow job for this annotation

GitHub Actions / modularpipeline (macos-latest) 

There is no argument given that corresponds to the required parameter 'action' of 'Polyfill.extension(string).Create<TState>(int, TState, SpanAction<char, TState>)'

Check failure on line 380 in TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs

View workflow job for this annotation

GitHub Actions / modularpipeline (windows-latest) 

There is no argument given that corresponds to the required parameter 'action' of 'Polyfill.extension(string).Create<TState>(int, TState, SpanAction<char, TState>)'

Check failure on line 380 in TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs

View workflow job for this annotation

GitHub Actions / modularpipeline (windows-latest) 

There is no argument given that corresponds to the required parameter 'action' of 'Polyfill.extension(string).Create<TState>(int, TState, SpanAction<char, TState>)'

Check failure on line 380 in TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs

View workflow job for this annotation

GitHub Actions / modularpipeline (ubuntu-latest) 

There is no argument given that corresponds to the required parameter 'action' of 'Polyfill.extension(string).Create<TState>(int, TState, SpanAction<char, TState>)'

Check failure on line 380 in TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs

View workflow job for this annotation

GitHub Actions / modularpipeline (ubuntu-latest) 

There is no argument given that corresponds to the required parameter 'action' of 'Polyfill.extension(string).Create<TState>(int, TState, SpanAction<char, TState>)'
}

private static string GetCss()
Expand Down
Loading