chore(deps): update microsoft.extensions to 10.0.5#5148
Conversation
There was a problem hiding this comment.
Code Review
This is a straightforward Renovate Bot patch update bumping three Microsoft.Extensions packages from 10.0.4 → 10.0.5. The changes are correct and consistent across all 4 affected files.
What's changing
| File | Change |
|---|---|
Directory.Packages.props |
Central version bump for DependencyInjection, Logging, and Logging.Abstractions |
TUnit.Logging.Microsoft/TUnit.Logging.Microsoft.csproj |
Version attribute updated on net8/net9 conditional references |
TUnit.Mocks.Logging/TUnit.Mocks.Logging.csproj |
Version attribute updated on net8/net9 conditional references |
TUnit.Templates/content/TUnit.FSharp/TestProject.fsproj |
Direct package reference bumped (template project, no central package management) |
Observations
Pre-existing pattern worth noting (not introduced by this PR):
In TUnit.Logging.Microsoft.csproj and TUnit.Mocks.Logging.csproj, the conditional per-TFM items use both Version and VersionOverride:
<PackageReference Include="Microsoft.Extensions.Logging" Version="10.0.5" VersionOverride="8.0.0" />The Version attribute here is redundant — VersionOverride is what actually controls the resolved version for that TFM, overriding the central Directory.Packages.props entry. The Version attribute alongside VersionOverride has no effect on NuGet resolution. This could be cleaned up to remove the Version attribute from these per-TFM conditional items (leaving it only in Directory.Packages.props), which would also mean Renovate wouldn't need to update them in future patch bumps. That said, this is a pre-existing issue outside this PR's scope.
Verdict
The PR is correct and safe to merge. The version bumps are applied consistently everywhere they need to be.
32a1e1d to
5b9d35e
Compare
There was a problem hiding this comment.
Code Review
This is a Renovate Bot patch update bumping three Microsoft.Extensions packages from 10.0.4 → 10.0.5 across 4 files. Reviewing against my previous comment — no new changes have been introduced.
Summary of changes
| File | Change |
|---|---|
Directory.Packages.props |
Central version bump for all 3 packages |
TUnit.Logging.Microsoft/TUnit.Logging.Microsoft.csproj |
net8/net9 conditional references updated |
TUnit.Mocks.Logging/TUnit.Mocks.Logging.csproj |
net8/net9 conditional references updated |
TUnit.Templates/content/TUnit.FSharp/TestProject.fsproj |
Direct reference updated (template, no central package management) |
Assessment
The changes are correct, minimal, and consistently applied across all affected files. No behavioral or API changes are expected from a patch-level Microsoft.Extensions bump.
Pre-existing note (not introduced here): The conditional per-TFM <PackageReference> entries in TUnit.Logging.Microsoft and TUnit.Mocks.Logging still carry a redundant Version attribute alongside VersionOverride. Since VersionOverride is what NuGet uses, the Version attribute has no effect and causes unnecessary churn in Renovate PRs like this one. Consider removing Version from those conditional items in a future cleanup — Renovate would then only need to update Directory.Packages.props.
Verdict: Safe to merge. ✓
This PR contains the following updates:
10.0.4→10.0.510.0.4→10.0.510.0.4→10.0.5Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Renovate Bot.