chore(deps): update dependency opentelemetry.instrumentation.aspnetcore to 1.15.1#5136
chore(deps): update dependency opentelemetry.instrumentation.aspnetcore to 1.15.1#5136
Conversation
There was a problem hiding this comment.
Code Review
This is a routine Renovate Bot PR bumping OpenTelemetry.Instrumentation.AspNetCore from 1.15.0 → 1.15.1 in two project files.
Assessment: ✅ LGTM
The change is minimal, safe, and correct. Both files are updated consistently.
One observation (non-blocking)
After this change, the OpenTelemetry packages within each project file are on slightly different versions:
OpenTelemetry.Exporter.OpenTelemetryProtocol 1.15.0
OpenTelemetry.Extensions.Hosting 1.15.0
OpenTelemetry.Instrumentation.AspNetCore 1.15.1 ← bumped
OpenTelemetry.Instrumentation.Http 1.15.0
OpenTelemetry.Instrumentation.Runtime 1.15.0
The OpenTelemetry .NET contrib packages do version independently, so this won't cause a runtime issue. However, in template and example projects (which developers copy directly), version inconsistency can cause confusion about whether the split is intentional.
If Renovate is configured to update packages individually as patches land (which is the default), this is expected behaviour. If you'd prefer all OpenTelemetry packages to stay in lockstep, a groupName rule in the Renovate config (e.g. grouping all opentelemetry* packages) would keep them aligned. This is purely a developer-experience suggestion and not a blocker for this PR.
Summary: Safe to merge as-is.
30d5837 to
0fa26f6
Compare
There was a problem hiding this comment.
Code Review (Follow-up)
A previous review was left on an earlier commit. After rebasing, the diff is identical in substance — only the two bumps for OpenTelemetry.Instrumentation.AspNetCore → .
Assessment: ✅ LGTM — no new issues
All points from the previous review still apply:
- Both files ( and ) are updated consistently.
- The version split across OpenTelemetry packages ( vs ) is benign since contrib packages version independently; the non-blocking suggestion to use a Renovate
groupNamerule to keep them in lockstep still stands as a developer-experience improvement, but is not a blocker.
Safe to merge.
There was a problem hiding this comment.
Code Review (Follow-up)
A previous review was left on an earlier commit. After rebasing, the diff is identical in substance — only the two PackageReference bumps for OpenTelemetry.Instrumentation.AspNetCore 1.15.0 to 1.15.1.
Assessment: LGTM — no new issues
All points from the previous review still apply:
- Both files (TUnit.Templates and examples/CloudShop) are updated consistently.
- The version split across OpenTelemetry packages (1.15.0 vs 1.15.1) is benign since contrib packages version independently; the non-blocking suggestion to use a Renovate
groupNamerule to keep them in lockstep still stands as a developer-experience improvement, but is not a blocker.
Safe to merge.
This PR contains the following updates:
1.15.0→1.15.1Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.