Skip to content

Fix HTML report sort to also reorder groups #5103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 1 commit into from
Mar 7, 2026
Merged

Fix HTML report sort to also reorder groups #5103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions TUnit.Engine/Reporters/Html/HtmlReportGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ private static void AppendHead(StringBuilder sb, ReportData data)
sb.AppendLine("<head>");
sb.AppendLine("<meta charset=\"UTF-8\">");
sb.AppendLine("<meta name=\"viewport\" content=\"width=device-width, initial-scale=1.0\">");
sb.AppendLine("<link rel=\"icon\" href=\"data:,\">");
sb.Append("<title>Test Report \u2014 ");
sb.Append(WebUtility.HtmlEncode(data.AssemblyName));
sb.AppendLine("</title>");
Expand Down Expand Up @@ -1204,7 +1205,7 @@ function highlight(text, query) {
function sortTests(tests) {
if (sortMode === 'duration') return [...tests].sort((a,b) => b.durationMs - a.durationMs);
if (sortMode === 'name') return [...tests].sort((a,b) => a.displayName.localeCompare(b.displayName));
return [...tests].sort((a,b) => (statusOrder[a.status]||9) - (statusOrder[b.status]||9));
return [...tests].sort((a,b) => (statusOrder[a.status]??9) - (statusOrder[b.status]??9));
}

function computeDisplayGroups() {
Expand Down Expand Up @@ -1532,10 +1533,20 @@ function renderSlowestSection() {
sec.innerHTML = h;
}

function sortGroups(grps) {
if (sortMode === 'duration') {
const maxDur = new Map(grps.map(g => [g, g.tests.length ? Math.max(...g.tests.map(t => t.durationMs)) : 0]));
return [...grps].sort((a,b) => maxDur.get(b) - maxDur.get(a));
}
if (sortMode === 'name') return [...grps].sort((a,b) => a.label.localeCompare(b.label));
const minStatus = new Map(grps.map(g => [g, g.tests.length ? Math.min(...g.tests.map(t => statusOrder[t.status] ?? 9)) : 9]));
return [...grps].sort((a,b) => minStatus.get(a) - minStatus.get(b));
}

function render() {
let total = 0;
let html = '';
const displayGroups = computeDisplayGroups();
const displayGroups = sortGroups(computeDisplayGroups());
const limited = displayGroups.slice(0, renderLimit);
limited.forEach((g,gi)=>{
const ft = sortTests(g.tests.filter(matchesFilter));
Expand Down
Loading