Skip to content

perf: remove Action allocation for token.Register#5075

Merged
thomhurst merged 1 commit intothomhurst:mainfrom
TimothyMakkison:register_state
Mar 4, 2026
Merged

perf: remove Action allocation for token.Register#5075
thomhurst merged 1 commit intothomhurst:mainfrom
TimothyMakkison:register_state

Conversation

@TimothyMakkison
Copy link
Contributor

Use CancellationToken.Register(Action<object?> callback, object? state) overload to pass a boxed ValueTuple of state into the function. This removes the Action allocation.

Before

image

After

image

@TimothyMakkison
Copy link
Contributor Author

FYI, gitguardian is flagging TUnit, I've marked it as erroneous, hopefully the issue won't persist

image

auto-merge was automatically disabled March 4, 2026 21:49

Head branch was pushed to by a user without write access

@TimothyMakkison
Copy link
Contributor Author

Added UnconditionalSuppressMessage tests should pass now

@thomhurst thomhurst merged commit 701964b into thomhurst:main Mar 4, 2026
10 of 11 checks passed
intellitect-bot pushed a commit to IntelliTect/EssentialCSharp.Web that referenced this pull request Mar 6, 2026
Updated [TUnit](https://github.com/thomhurst/TUnit) from 1.18.21 to
1.18.37.

<details>
<summary>Release notes</summary>

_Sourced from [TUnit's
releases](https://github.com/thomhurst/TUnit/releases)._

## 1.18.37

<!-- Release notes generated using configuration in .github/release.yml
at v1.18.37 -->

## What's Changed
### Other Changes
* Improve HTML report perf by @​slang25 in
thomhurst/TUnit#5077
* perf: remove `Action` allocation for `token.Register` by
@​TimothyMakkison in thomhurst/TUnit#5075
* fix(mocks): escape C# keyword parameter names in generated mock code
by @​thomhurst in thomhurst/TUnit#5091
* Support static abstract interface members in mock generation by
@​thomhurst in thomhurst/TUnit#5070
### Dependencies
* chore(deps): update tunit to 1.18.21 by @​thomhurst in
thomhurst/TUnit#5076
* chore(deps): update dependency polyfill to 9.16.0 by @​thomhurst in
thomhurst/TUnit#5080
* chore(deps): update dependency polyfill to 9.16.0 by @​thomhurst in
thomhurst/TUnit#5079
* chore(deps): update dependency polyfill to 9.17.0 by @​thomhurst in
thomhurst/TUnit#5082
* chore(deps): update dependency polyfill to 9.17.0 by @​thomhurst in
thomhurst/TUnit#5081
* chore(deps): update dependency polly to 8.6.6 by @​thomhurst in
thomhurst/TUnit#5084
* chore(deps): update dependency humanizer to 3.0.8 by @​thomhurst in
thomhurst/TUnit#5087
* chore(deps): update dependency polyfill to 9.18.0 by @​thomhurst in
thomhurst/TUnit#5090
* chore(deps): update dependency polyfill to 9.18.0 by @​thomhurst in
thomhurst/TUnit#5089


**Full Changelog**:
thomhurst/TUnit@v1.18.21...v1.18.37

Commits viewable in [compare
view](thomhurst/TUnit@v1.18.21...v1.18.37).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=TUnit&package-manager=nuget&previous-version=1.18.21&new-version=1.18.37)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants