Conversation
There was a problem hiding this comment.
Code Review: chore(deps): update tunit to 1.18.0
This is a straightforward Renovate bot dependency update bumping all TUnit packages from 1.17.54 to 1.18.0. The changes are minimal and mechanical.
What Changed
All TUnit package references are uniformly updated across two locations:
Directory.Packages.props— central version management for 6 packages (TUnit, TUnit.AspNetCore, TUnit.Core, TUnit.Engine, TUnit.Assertions, TUnit.Assertions.FSharp)TUnit.Templates/content/— template project files for 5 templates, hardcoding explicit versions as expected for end-user templates
Assessment
The changes are correct and complete. All affected packages are updated consistently to the same target version (1.18.0), and no package appears to have been missed.
Notable release highlights in 1.18.0 (visible in the PR description):
- Several significant perf wins: ~18k fewer JIT compilations from per-class helper generation, ~27k fewer JITs from TestSource consolidation, and metadata creation made fully synchronous
- Bug fix for
IsEquivalentTofalling back toEquals()for types with no public members - Rich HTML test reports feature
Template versioning design: The template files intentionally use hardcoded versions (separate from central package management), which is the correct approach — templates are shipped as-is to end users who need a concrete, pinned version to start from. The dual-update pattern is expected here.
No issues found. This is a clean, routine dependency bump that should be safe to merge with auto-merge enabled.
a209653 to
764f6bd
Compare
There was a problem hiding this comment.
Code Review: chore(deps): update tunit to 1.18.0
This is a straightforward Renovate Bot dependency update bumping all TUnit-family packages from 1.17.54 → 1.18.0. Here's my analysis:
What's Changed
7 packages updated consistently across two locations:
Directory.Packages.props— central package version management for internal test/example projectsTUnit.Templates/content/— project scaffold templates shipped to end-users
Assessment
No issues found. The update is clean and consistent:
- All 7 packages (
TUnit,TUnit.Assertions,TUnit.Assertions.FSharp,TUnit.Core,TUnit.Engine,TUnit.AspNetCore,TUnit.Playwright) are bumped in lockstep — no version drift between related packages. - Template files correctly pin to an explicit released version (rather than floating
*or1.18.*), which is the right approach for project scaffolds. Users get a reproducible, known-good starting point. - The
1.18.0release includes meaningful improvements this repo ships: significant JIT reduction (~45k fewer per the release notes), theIsEquivalentTobug fix, and the new rich HTML test reports feature — all good reasons to have templates point at this version.
Minor Observation
The template files in TUnit.Templates/content/ carry pinned versions independently of Directory.Packages.props. If these ever drift (e.g., a future Renovate run misses one), users could scaffold projects with mixed versions. This is an existing structural pattern, not introduced by this PR, but worth noting for the long term. A single source-of-truth for template versions (e.g., MSBuild property injection at template pack time) would eliminate that risk entirely — but that's a separate refactoring concern.
Approved as-is.
Updated [TUnit](https://github.com/thomhurst/TUnit) from 1.18.0 to 1.18.9. <details> <summary>Release notes</summary> _Sourced from [TUnit's releases](https://github.com/thomhurst/TUnit/releases)._ ## 1.18.9 <!-- Release notes generated using configuration in .github/release.yml at v1.18.9 --> ## What's Changed ### Other Changes * perf: reduce source-gen JIT overhead via metadata factory helpers by @thomhurst in thomhurst/TUnit#5056 * perf: add ParameterMetadataFactory and lazy ReflectionInfo resolution by @thomhurst in thomhurst/TUnit#5057 * feat: distributed trace collection for HTML report by @thomhurst in thomhurst/TUnit#5059 ### Dependencies * chore(deps): update tunit to 1.18.0 by @thomhurst in thomhurst/TUnit#5052 * chore(deps): update docker/setup-docker-action action to v5 by @thomhurst in thomhurst/TUnit#5058 **Full Changelog**: thomhurst/TUnit@v1.18.0...v1.18.9 Commits viewable in [compare view](thomhurst/TUnit@v1.18.0...v1.18.9). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This PR contains the following updates:
1.17.54→1.18.01.17.54→1.18.01.17.54→1.18.01.17.54→1.18.01.17.54→1.18.01.17.54→1.18.01.17.54→1.18.0Release Notes
thomhurst/TUnit (TUnit)
v1.18.0: 1.18.0What's Changed
Other Changes
--results-directoryin documentation by @vbreuss in #5038Dependencies
Full Changelog: v1.17.54...v1.18.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Renovate Bot.