Skip to content

use strong typed Enum.Parse #4986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 3 commits into from
Feb 25, 2026
Merged

use strong typed Enum.Parse #4986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
176b254
use strong typed Enum.Parse
SimonCropp Feb 23, 2026
1ed62c7
Refactor hook level parsing into helper
SimonCropp Feb 23, 2026
39d12e3
Simplify IsClassConstructorAttribute signature
SimonCropp Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion TUnit.Analyzers/ClassParametersAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ private void AnalyzeSymbol(SymbolAnalysisContext context)
.SelectMany(x => x.GetAttributes())
.Concat(namedTypeSymbol.ContainingAssembly.GetAttributes())
.Any(x => x.IsDataSourceAttribute(context.Compilation) ||
x.IsClassConstructorAttribute(context.Compilation));
x.IsClassConstructorAttribute());

if (!hasDataSourceOrClassConstructor)
{
Expand Down
18 changes: 10 additions & 8 deletions TUnit.Analyzers/Extensions/AttributeExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public static bool IsStandardHook(this AttributeData attributeData, Compilation
{
hookType = HookType.Before;
type = attributeData.AttributeClass!;
hookLevel = (HookLevel?) Enum.Parse(typeof(HookLevel), attributeData.ConstructorArguments.First().ToCSharpString().Split('.').Last());
hookLevel = ParseHookLevel(attributeData);
return true;
}

Expand All @@ -44,7 +44,7 @@ public static bool IsStandardHook(this AttributeData attributeData, Compilation
{
hookType = HookType.After;
type = attributeData.AttributeClass!;
hookLevel = (HookLevel?) Enum.Parse(typeof(HookLevel), attributeData.ConstructorArguments.First().ToCSharpString().Split('.').Last());
hookLevel = ParseHookLevel(attributeData);
return true;
}

Expand All @@ -63,7 +63,7 @@ public static bool IsEveryHook(this AttributeData attributeData, Compilation com
{
hookType = HookType.Before;
type = attributeData.AttributeClass!;
hookLevel = (HookLevel?) Enum.Parse(typeof(HookLevel), attributeData.ConstructorArguments.First().ToCSharpString().Split('.').Last());
hookLevel = ParseHookLevel(attributeData);

return true;
}
Expand All @@ -74,7 +74,7 @@ public static bool IsEveryHook(this AttributeData attributeData, Compilation com
{
hookType = HookType.After;
type = attributeData.AttributeClass!;
hookLevel = (HookLevel?) Enum.Parse(typeof(HookLevel), attributeData.ConstructorArguments.First().ToCSharpString().Split('.').Last());
hookLevel = ParseHookLevel(attributeData);

return true;
}
Expand Down Expand Up @@ -119,7 +119,7 @@ public static bool IsDataSourceAttribute(this AttributeData? attributeData, Comp
return attributeData.AttributeClass.AllInterfaces.Contains(dataAttributeInterface, SymbolEqualityComparer.Default);
}

public static bool IsClassConstructorAttribute(this AttributeData? attributeData, Compilation compilation)
public static bool IsClassConstructorAttribute(this AttributeData? attributeData)
{
if (attributeData?.AttributeClass is null)
{
Expand All @@ -129,7 +129,7 @@ public static bool IsClassConstructorAttribute(this AttributeData? attributeData
var baseType = attributeData.AttributeClass;
while (baseType != null)
{
if (baseType.Name == "BaseClassConstructorAttribute" ||
if (baseType.Name == "BaseClassConstructorAttribute" ||
baseType.Name == "ClassConstructorAttribute")
{
return true;
Expand All @@ -140,8 +140,10 @@ public static bool IsClassConstructorAttribute(this AttributeData? attributeData
return false;
}

public static string GetHookType(this AttributeData attributeData)
private static HookLevel ParseHookLevel(AttributeData attributeData)
{
return attributeData.ConstructorArguments[0].ToCSharpString();
var span = attributeData.ConstructorArguments.First().ToCSharpString().AsSpan();
var lastDot = span.LastIndexOf('.');
return Enum.Parse<HookLevel>(lastDot < 0 ? span : span[(lastDot + 1)..]);
}
}
Loading