fix: propagate CancellationToken to inner loop in AotConverterGenerator#4916
Merged
fix: propagate CancellationToken to inner loop in AotConverterGenerator#4916
Conversation
…ConverterGenerator The ScanTestParameters method accepted a CancellationToken but only checked it at the start of the outer syntax tree loop. The inner loop over DescendantNodes — which can iterate over a very large number of nodes per syntax tree — did not check for cancellation, causing the generator to remain unresponsive to cancellation requests during long-running node traversals. Closes #4900
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. This is a clean, well-targeted fix. Adding The dual-mode rule does not apply here since |
This was referenced Feb 22, 2026
Open
This was referenced Feb 23, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cancellationToken.ThrowIfCancellationRequested()at the start of theDescendantNodes()inner loop inScanTestParameters, ensuring the generator responds to cancellation during long-running node traversalstypesToScanloop already had cancellation checks, but the potentially large inner loop over all descendant nodes in each tree did notTest plan
dotnet build TUnit.Core.SourceGenerator/TUnit.Core.SourceGenerator.csprojsucceeds with zero warnings and zero errorsCloses #4900