fix: catch specific exceptions in VerbosityService (#4901)#4907
Merged
fix: catch specific exceptions in VerbosityService (#4901)#4907
Conversation
Replace bare catch block with catch (Exception ex) and add debug logging via System.Diagnostics.Debug.WriteLine to avoid silently swallowing errors when determining console environment. Closes #4901
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. This is a clean, well-scoped fix:
Good fix. |
This was referenced Feb 22, 2026
Open
This was referenced Feb 23, 2026
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
catchblock inVerbosityService.IsConsoleEnvironmentwithcatch (Exception ex)to explicitly catch typed exceptionsSystem.Diagnostics.Debug.WriteLinelogging so failures in console environment detection are visible during debugging rather than silently swallowedCloses #4901
Test plan
dotnet build TUnit.Engine/TUnit.Engine.csprojpasses with zero warnings and zero errorsIsConsoleEnvironment(e.g., via a debugger or diagnostic listener)