refactor: simplify tuple handling with #if for newer TFMs#4790
Merged
refactor: simplify tuple handling with #if for newer TFMs#4790
Conversation
Use ITuple interface on net8.0+ to replace arity-specific overloads: - DataConversionHelper: single ITuple-based UnwrapTuple and ConvertAsyncEnumerableTupleToObjectArrays - TupleExtensions: single ITuple-based ToObjectArray replacing 7 overloads - DataSourceHelpers: gate 7 unused generic UnwrapTuple overloads, remove duplicate IsTupleType - DataUnwrapper: remove duplicate IsTupleType, use TupleHelper.IsTupleType All arity-specific overloads preserved on netstandard2.0 via #else. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. This is a clean refactoring that properly leverages the |
This was referenced Feb 14, 2026
Open
This was referenced Feb 16, 2026
Chore(deps): Bump TUnit.Assertions from 1.12.111 to 1.15.0
code-of-chaos/cs_code-of_chaos-testing#91
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ITupleinterface onnet8.0+to replace arity-specific tuple overloads, keeping them only onnetstandard2.0via#elseIsTupleType(Type)methods inDataUnwrapperandDataSourceHelperswith existingTupleHelper.IsTupleType(Type)UnwrapTupleoverloads inDataSourceHelperstonetstandard2.0onlyTest plan
netstandard2.0,net8.0,net9.0,net10.0)net472,net8.0,net9.0,net10.0)Net4_7snapshot unchanged (netstandard2.0 API preserved)🤖 Generated with Claude Code