fix: disable IDE streaming sink by default to prevent test runner crashes#4751
Merged
fix: disable IDE streaming sink by default to prevent test runner crashes#4751
Conversation
…shes The IdeStreamingSink causes crashes in Rider and VS Code due to the Microsoft Testing Platform's TestApplicationResult.ConsumeAsync throwing on duplicate TestNodeUid keys. Gate the feature behind the TUNIT_ENABLE_IDE_STREAMING=1 environment variable so users can opt in. Closes #4749 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. This is a clean, well-scoped fix that:
The approach is sound: disabling a problematic feature by default while allowing users to enable it when needed is the right trade-off for stability. |
This was referenced Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IdeStreamingSinkby default — it was causing crashes in Rider and VS Code when tests write toConsole.WriteLinefollowed by an async delayTestApplicationResult.ConsumeAsyncthrowingArgumentExceptionon duplicateTestNodeUidkeys, triggered by the sink's output update + heartbeat patternTUNIT_ENABLE_IDE_STREAMING=1environment variable for users who want real-time output streamingCloses #4749
Test plan
Console.WriteLine+Task.Delayno longer crash in Rider/VS CodeTUNIT_ENABLE_IDE_STREAMING=1re-enables the streaming behaviorConsoleOutputSink/TestOutputSink)🤖 Generated with Claude Code