Skip to content

perf: remove List usage from AttributeWriter #4692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 1 commit into from
Feb 6, 2026
Merged

perf: remove List usage from AttributeWriter #4692

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 24 additions & 28 deletions TUnit.Core.SourceGenerator/CodeGenerators/Writers/AttributeWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,50 +13,46 @@ public class AttributeWriter(Compilation compilation, TUnit.Core.SourceGenerator
public void WriteAttributes(ICodeWriter sourceCodeWriter,
IEnumerable<AttributeData> attributeDatas)
{
var attributesToWrite = new List<AttributeData>();
var first = true;

// Filter out attributes that we can write
foreach (var attributeData in attributeDatas)
{
// Include attributes with syntax reference (from current compilation)
// Include attributes without syntax reference (from other assemblies) as long as they have an AttributeClass
if (attributeData.ApplicationSyntaxReference is not null || attributeData.AttributeClass is not null)
if (attributeData.ApplicationSyntaxReference is null && attributeData.AttributeClass is null)
{
// Skip compiler-internal and assembly-level attributes
if (ShouldSkipCompilerInternalAttribute(attributeData))
{
continue;
}
continue;
}

// Skip framework-specific attributes when targeting older frameworks
// We determine this by checking if we can compile the attribute
if (ShouldSkipFrameworkSpecificAttribute(attributeData))
{
continue;
}
// Skip compiler-internal and assembly-level attributes
if (ShouldSkipCompilerInternalAttribute(attributeData))
{
continue;
}

// Skip attributes with compiler-generated type arguments
if (attributeData.ConstructorArguments.Any(arg =>
// Skip framework-specific attributes when targeting older frameworks
// We determine this by checking if we can compile the attribute
if (ShouldSkipFrameworkSpecificAttribute(attributeData))
{
continue;
}

// Skip attributes with compiler-generated type arguments
if (attributeData.ConstructorArguments.Any(arg =>
arg is { Kind: TypedConstantKind.Type, Value: ITypeSymbol typeSymbol } &&
typeSymbol.IsCompilerGeneratedType()))
{
continue;
}

attributesToWrite.Add(attributeData);
{
continue;
}
}

for (var index = 0; index < attributesToWrite.Count; index++)
{
var attributeData = attributesToWrite[index];

WriteAttribute(sourceCodeWriter, attributeData);

if (index != attributesToWrite.Count - 1)
if (!first)
{
sourceCodeWriter.AppendLine(",");
}

WriteAttribute(sourceCodeWriter, attributeData);
first = false;
}
}

Expand Down
Loading