perf: guard debug logging to avoid string allocations#4682
Merged
Conversation
Add IsDebugEnabled property and wrap all LogDebugAsync calls in hot paths with a check. This prevents interpolated string allocations when debug logging is disabled, which is the common case in production. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. This PR is a clean performance optimization that aligns perfectly with CLAUDE.md Rule 4 (Performance First). The IsDebugEnabled property logic is correct (mathematically equivalent to IsEnabled(LogLevel.Debug)), and the guard pattern effectively prevents unnecessary string interpolations in hot paths when debug logging is disabled. The changes are in the unified execution path after metadata collection, so Rule 1 (Dual-Mode) does not apply. All 13 guarded log calls follow a consistent mechanical pattern with no logic errors or side effects. |
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
This was referenced Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code