fix: skip tests when transitive dependencies fail #4646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #4643 When Test3 depends on Test2, which depends on Test1, and Test1 fails: - Test2 is correctly skipped (direct dependency) - Test3 was incorrectly running instead of being skipped Changed TestRunner to skip tests when dependencies have any non-Passed state (Failed, Skipped, Timeout, Cancelled), not just Failed state. This ensures transitive dependencies are properly handled. Changes: - Updated TestRunner.cs condition from `State == TestState.Failed` to `State != TestState.Passed` - Added TransitiveDependenciesTests to reproduce and verify the fix
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. Review Summary: This PR provides a clean and focused fix for transitive dependency handling. The change from Strengths:
The logic is sound and the implementation is correct. |
This was referenced Feb 3, 2026
Merged
Closed
This was referenced Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4643 - Tests are now correctly skipped when transitive dependencies fail.
Problem
When using
DependsOnattribute with transitive dependencies:Root Cause
TestRunner.cs:81only checked if dependency state wasFailed, but when Test2 is skipped due to Test1 failing, Test3 sees Test2 inSkippedstate and proceeds to run.Solution
Changed condition from
State == TestState.FailedtoState != TestState.Passed, ensuring any non-successful dependency state (Skipped, Failed, Timeout, Cancelled) blocks execution.Changes
TUnit.Engine/Scheduling/TestRunner.cs- Updated dependency check conditionTransitiveDependenciesTeststo reproduce and validate the fixTest Plan