perf: make StaticPropertyInitializationGenerator incremental#4638
Merged
thomhurst merged 1 commit intothomhurst:mainfrom Feb 6, 2026
Merged
Conversation
3e61587 to
b2ae4c2
Compare
b2ae4c2 to
91c570b
Compare
Contributor
Author
Time and memory usage seems suspiciously low 🤔 but the tests appear to pass |
486c58e to
4ccfdb3
Compare
4ccfdb3 to
9d6a975
Compare
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. This is a well-structured performance optimization that properly implements incremental source generation patterns. The separation of parsing and generation phases, introduction of value-based model types, and proper use of EquatableArray all follow Roslyn best practices for incremental generators. |
This was referenced Feb 6, 2026
This was referenced Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PropertyWithDataSourceModeland associated typesImmutableArray<PropertyWithDataSource>fromGetSemanticTargetForGenerationenabledProvidercheck to earlier in pipeline to reduce workToUniquePropertyModelsensures that only distinct properties are converter intoPropertyWithDataSourceModelGetStaticPropertyDataSourcesinstead of doing a unnecessary call inGenerateStaticPropertyInitialization