Skip to content

fix: TUnit0059 false positive when no subclasses exist in assembly #4608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thomhurst merged 1 commit into from
Jan 29, 2026
Merged

fix: TUnit0059 false positive when no subclasses exist in assembly #4608

thomhurst merged 1 commit into from
Jan 29, 2026

Conversation

@thomhurst
Copy link
Owner

@thomhurst thomhurst commented Jan 29, 2026

Summary

  • Fix false positive TUnit0059 warning when an abstract test class with data sources has no concrete subclasses in the same assembly
  • This supports the "testing library" pattern where abstract test classes are defined in a library meant to be subclassed by consuming assemblies

Changes

  • Modified AbstractTestClassWithDataSourcesAnalyzer to track whether any concrete subclasses exist
  • Added filter to only consider source-defined types (not from referenced assemblies)
  • Updated diagnostic logic to only warn when there ARE concrete subclasses that are missing [InheritsTests]
  • Updated tests to reflect the new expected behavior

Behavior

Scenario Old Behavior New Behavior
Abstract class with no subclasses ⚠️ Warning ✅ No warning
Abstract class with subclass missing [InheritsTests] ⚠️ Warning ⚠️ Warning
Abstract class with subclass having [InheritsTests] ✅ No warning ✅ No warning

Fixes #4607

Test plan

  • Updated existing analyzer tests
  • All AbstractTestClassWithDataSourcesAnalyzerTests pass

@thomhurst
fix: TUnit0059 false positive when no subclasses exist in assembly
ef04f2c 
Don't warn about abstract test classes with data sources when there are
no concrete subclasses in the same assembly. This supports the library
pattern where abstract test classes are meant to be subclassed by
consuming assemblies.

Fixes #4607
@claude
Copy link
Contributor

claude bot commented Jan 29, 2026

No issues found. Checked for bugs and CLAUDE.md compliance.

@thomhurst thomhurst merged commit 8592e29 into main Jan 29, 2026
12 of 13 checks passed
@thomhurst thomhurst deleted the fix/tunit0059-false-positive-no-subclasses branch January 29, 2026 20:23
This was referenced Jan 29, 2026
Open
Merged
Open
Merged
Open
Open
Open
Merged
Open
Open
Open
Merged
Merged
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: TUnit0059 false positive when there are no subclasses in the same assembly

2 participants

@thomhurst