fix: session hooks in referenced library projects not executing #4599
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4583 -
[Before(TestSession)]and[After(TestSession)]hooks defined in referenced library projects were not executing.Problem
The
InfrastructureGeneratorgenerates code to load referenced assemblies early (to trigger their module initializers which register hooks). However, theHasPhysicalLocationcheck was too restrictive:This only accepted
PortableExecutableReferenceobjects. During IDE design-time builds, project-to-project references are represented asCompilationReferenceobjects. The incremental generator may cache results from these builds, resulting in missingAssembly.Load()calls for library projects.Solution
HasPhysicalLocationtoIsLoadableAtRuntimeto better reflect its purposeTest Plan
LibraryTestSessionHooksclass toTUnit.TestProject.Librarywith[Before(TestSession)]and[After(TestSession)]hooksLibraryTestSessionHookTestsinTUnit.TestProjectto verify the library's hooks executedotnet run -- --treenode-filter "/*/*/LibraryTestSessionHookTests/*"