feat: reorder After(TestDiscovery) hooks to run before event receivers #4597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the execution order so that After(TestDiscovery) hooks run after dependencies are resolved but before ITestRegisteredEventReceiver and ITestDiscoveryEventReceiver are invoked. This allows hooks to set up state that event receivers can use during registration. Also reorders ITestDiscoveryEventReceiver to fire before ITestRegisteredEventReceiver for semantic clarity - discovery events should fire before registration events. New execution order: 1. Before(TestDiscovery) hooks 2. Test discovery & building 3. Dependency resolution 4. After(TestDiscovery) hooks (discovery phase complete) 5. ITestDiscoveryEventReceiver.OnTestDiscovered() 6. ITestRegisteredEventReceiver.OnTestRegistered() (registration phase)
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
This was referenced Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After(TestDiscovery)hooks to run after dependency resolution but beforeITestRegisteredEventReceiverandITestDiscoveryEventReceiverare invokedITestDiscoveryEventReceiverto fire beforeITestRegisteredEventReceiverfor semantic clarityExecuteAfterTestDiscoveryHooksAsynccall toDiscoverTestsFullyStreamingAsyncThis allows
After(TestDiscovery)hooks to set up state that event receivers can use during the registration phase.New execution order:
Before(TestDiscovery)hooksAfter(TestDiscovery)hooks (discovery phase complete)ITestDiscoveryEventReceiver.OnTestDiscovered()ITestRegisteredEventReceiver.OnTestRegistered()(registration phase)Test plan
DependenciesAvailableInEventReceiverTestspassTransitiveDependenciesInEventReceiverTestspassCrossClassDependenciesInEventReceiverTestspass