-
-
Notifications
You must be signed in to change notification settings - Fork 110
docs: fix incorrect API references in dynamic tests documentation #4567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SummaryFixes incorrect API references in dynamic tests documentation. Critical IssuesNone found SuggestionsThe changes are accurate and well-verified:
The PR author did thorough verification by checking actual test files that use these APIs. VerdictAPPROVE - No critical issues This is a documentation-only PR that does not trigger any TUnit critical rules. |
- Change `DynamicTest.Argument<T>()` to `DynamicTestHelper.Argument<T>()` which is the actual helper class name - Remove non-existent `[RunOnDiscovery]` attribute from Runtime example Fixes #4523 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
cd4a172 to
084cde5
Compare
SummaryFixes incorrect API references in dynamic tests documentation - corrects Critical IssuesNone found ✅ SuggestionsNone - the changes are accurate and well-tested against the actual codebase. Verification✅ Confirmed Verdict✅ APPROVE - Documentation fix is accurate and improves clarity for users |
Summary
DynamicTest.Argument<T>()→DynamicTestHelper.Argument<T>()(the actual helper class name)[RunOnDiscovery]attribute from Runtime exampleFixes #4523
Test plan
TUnit.TestProject/Bugs/3173/DynamicTestArgumentsTests.cs,TUnit.TestProject/DynamicTests/Basic2.cs)DynamicTestHelperis the actual class name inTUnit.Core/AbstractDynamicTest.cs[RunOnDiscovery]attribute doesn't exist anywhere in the codebaseTUnitWIP0001diagnostic doesn't exist - removed unnecessary pragma from examples🤖 Generated with Claude Code