perf: use shared Task.FromResult(Passed)

TUnit.Assertions/Assertions/Enums/EnumAssertions.cs

@@ -35,7 +35,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TEnum> me
 
         if (enumValue.HasFlag(enumFlag))
         {
-            return Task.FromResult(AssertionResult.Passed);
+            return AssertionResult._passedTask;
         }
 
         return Task.FromResult(AssertionResult.Failed($"value {value} does not have flag {_expectedFlag}"));
@@ -75,7 +75,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TEnum> me
 
         if (!enumValue.HasFlag(enumFlag))
         {
-            return Task.FromResult(AssertionResult.Passed);
+            return AssertionResult._passedTask;
         }
 
         return Task.FromResult(AssertionResult.Failed($"value {value} has flag {_unexpectedFlag}"));
@@ -112,7 +112,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TEnum> me
         if (Enum.IsDefined(typeof(TEnum), value))
 #endif
         {
-            return Task.FromResult(AssertionResult.Passed);
+            return AssertionResult._passedTask;
         }
 
         return Task.FromResult(AssertionResult.Failed($"value {value} is not defined in {typeof(TEnum).Name}"));
@@ -149,7 +149,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TEnum> me
         if (!Enum.IsDefined(typeof(TEnum), value))
 #endif
         {
-            return Task.FromResult(AssertionResult.Passed);
+            return AssertionResult._passedTask;
         }
 
         return Task.FromResult(AssertionResult.Failed($"value {value} is defined in {typeof(TEnum).Name}"));
@@ -189,7 +189,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TEnum> me
 
         if (valueName == otherName)
         {
-            return Task.FromResult(AssertionResult.Passed);
+            return AssertionResult._passedTask;
         }
 
         return Task.FromResult(AssertionResult.Failed($"value name \"{valueName}\" does not equal \"{otherName}\""));
@@ -230,7 +230,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TEnum> me
 
         if (valueAsInt == otherAsInt)
         {
-            return Task.FromResult(AssertionResult.Passed);
+            return AssertionResult._passedTask;
         }
 
         return Task.FromResult(AssertionResult.Failed($"value {valueAsInt} does not equal {otherAsInt}"));
@@ -270,7 +270,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TEnum> me
 
         if (valueName != otherName)
         {
-            return Task.FromResult(AssertionResult.Passed);
+            return AssertionResult._passedTask;
         }
 
         return Task.FromResult(AssertionResult.Failed($"value name \"{valueName}\" equals \"{otherName}\""));
@@ -310,7 +310,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TEnum> me
 
         if (valueAsInt != otherAsInt)
         {
-            return Task.FromResult(AssertionResult.Passed);
+            return AssertionResult._passedTask;
         }
 
         return Task.FromResult(AssertionResult.Failed($"value {valueAsInt} equals {otherAsInt}"));

TUnit.Assertions/Assertions/Regex/MatchIndexAssertion.cs

@@ -52,7 +52,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<RegexMatc
         }
 
         // If we have a match, the assertion passed
-        return Task.FromResult(AssertionResult.Passed);
+        return AssertionResult._passedTask;
     }
 
     protected override string GetExpectation() => $"match at index {_index} to exist";

TUnit.Assertions/Assertions/Strings/ParseAssertions.cs

@@ -47,7 +47,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<string> m
 
         if (TryParse(value, _formatProvider, out _))
         {
-            return Task.FromResult(AssertionResult.Passed);
+            return AssertionResult._passedTask;
         }
 
         return Task.FromResult(AssertionResult.Failed($"\"{value}\" cannot be parsed into {typeof(T).Name}"));
@@ -146,12 +146,12 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<string> m
 
         if (value == null)
         {
-            return Task.FromResult(AssertionResult.Passed); // null cannot be parsed
+            return AssertionResult._passedTask; // null cannot be parsed
         }
 
         if (!TryParse(value, _formatProvider, out _))
         {
-            return Task.FromResult(AssertionResult.Passed);
+            return AssertionResult._passedTask;
         }
 
         return Task.FromResult(AssertionResult.Failed($"\"{value}\" can be parsed into {typeof(T).Name}"));
@@ -330,7 +330,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<T> metada
             return Task.FromResult(AssertionResult.Failed($"parsing failed: {exception.Message}"));
         }
 
-        return Task.FromResult(AssertionResult.Passed);
+        return AssertionResult._passedTask;
     }
 
     protected override string GetExpectation() => $"to be parsable into {typeof(T).Name}";

TUnit.Assertions/Collections/MemoryAssertions.cs

@@ -565,7 +565,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TMemory>
 
         if (passed)
         {
-            return Task.FromResult(AssertionResult.Passed);
+            return AssertionResult._passedTask;
         }
 
         return Task.FromResult(AssertionResult.Failed($"found {actualCount}"));

TUnit.Assertions/Conditions/BetweenAssertion.cs

@@ -89,7 +89,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TValue> m
 
         if (minOk && maxOk)
         {
-            return Task.FromResult(AssertionResult.Passed);
+            return AssertionResult._passedTask;
         }
 
         return Task.FromResult(AssertionResult.Failed($"found {value}"));

TUnit.Assertions/Conditions/CollectionAssertions.cs

@@ -702,7 +702,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TCollecti
 
         if (enumerated.SequenceEqual(ordered))
         {
-            return Task.FromResult(AssertionResult.Passed);
+            return AssertionResult._passedTask;
         }
 
         for (int i = 1; i < enumerated.Length; i++)
@@ -716,7 +716,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TCollecti
             }
         }
 
-        return Task.FromResult(AssertionResult.Passed);
+        return AssertionResult._passedTask;
     }
 
     protected override string GetExpectation() => "to be ordered by key selector in ascending order";
@@ -764,7 +764,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TCollecti
 
         if (enumerated.SequenceEqual(ordered))
         {
-            return Task.FromResult(AssertionResult.Passed);
+            return AssertionResult._passedTask;
         }
 
         for (int i = 1; i < enumerated.Length; i++)
@@ -778,7 +778,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TCollecti
             }
         }
 
-        return Task.FromResult(AssertionResult.Passed);
+        return AssertionResult._passedTask;
     }
 
     protected override string GetExpectation() => "to be ordered by key selector in descending order";

TUnit.Assertions/Conditions/CollectionNullAssertion.cs

@@ -22,7 +22,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TCollecti
 
         if (value != null)
         {
-            return Task.FromResult(AssertionResult.Passed);
+            return AssertionResult._passedTask;
         }
 
         return Task.FromResult(AssertionResult.Failed("value is null"));

TUnit.Assertions/Conditions/DateTimeSpecializedAssertions.cs

@@ -21,7 +21,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<DateTime>
     {
         if (metadata.Value == _expected)
         {
-            return Task.FromResult(AssertionResult.Passed);
+            return AssertionResult._passedTask;
         }
 
         return Task.FromResult(AssertionResult.Failed(

TUnit.Assertions/Conditions/DictionaryAssertions.cs

@@ -67,7 +67,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TDictiona
 
         if (found)
         {
-            return Task.FromResult(AssertionResult.Passed);
+            return AssertionResult._passedTask;
         }
 
         return Task.FromResult(AssertionResult.Failed($"key {_expectedKey} not found"));
@@ -112,7 +112,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TDictiona
 
         if (!value.ContainsKey(_expectedKey))
         {
-            return Task.FromResult(AssertionResult.Passed);
+            return AssertionResult._passedTask;
         }
 
         return Task.FromResult(AssertionResult.Failed($"key {_expectedKey} was found"));

TUnit.Assertions/Conditions/EqualsAssertion.cs

@@ -89,7 +89,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TValue> m
             var result = DeepEquals(value, _expected, _ignoredTypes, visited);
             if (result.IsSuccess)
             {
-                return Task.FromResult(AssertionResult.Passed);
+                return AssertionResult._passedTask;
             }
 
             return Task.FromResult(AssertionResult.Failed(result.Message ?? $"found {value}"));
@@ -100,7 +100,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TValue> m
 
         if (comparer.Equals(value!, _expected!))
         {
-            return Task.FromResult(AssertionResult.Passed);
+            return AssertionResult._passedTask;
         }
 
         return Task.FromResult(AssertionResult.Failed($"found {value}"));

TUnit.Assertions/Conditions/EquatableAssertion.cs

@@ -40,7 +40,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TActual>
         // Use IEquatable<TExpected>.Equals for comparison
         if (value.Equals(_expected))
         {
-            return Task.FromResult(AssertionResult.Passed);
+            return AssertionResult._passedTask;
         }
 
         return Task.FromResult(AssertionResult.Failed($"found {value}"));
@@ -85,7 +85,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TActual?>
         // Use IEquatable<TExpected>.Equals for comparison
         if (value.Value.Equals(_expected))
         {
-            return Task.FromResult(AssertionResult.Passed);
+            return AssertionResult._passedTask;
         }
 
         return Task.FromResult(AssertionResult.Failed($"found {value.Value}"));

TUnit.Assertions/Conditions/ExceptionPropertyAssertions.cs

@@ -45,7 +45,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TExceptio
 
         if (exception.Message.Contains(_expectedSubstring, _comparison))
         {
-            return Task.FromResult(AssertionResult.Passed);
+            return AssertionResult._passedTask;
         }
 
         return Task.FromResult(AssertionResult.Failed($"exception message was \"{exception.Message}\""));
@@ -91,7 +91,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TExceptio
 
         if (string.Equals(exception.Message, _expectedMessage, _comparison))
         {
-            return Task.FromResult(AssertionResult.Passed);
+            return AssertionResult._passedTask;
         }
 
         return Task.FromResult(AssertionResult.Failed($"exception message was \"{exception.Message}\""));
@@ -141,7 +141,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TExceptio
                 $"exception message \"{exception.Message}\" should not contain \"{_notExpectedSubstring}\""));
         }
 
-        return Task.FromResult(AssertionResult.Passed);
+        return AssertionResult._passedTask;
     }
 
     protected override string GetExpectation() =>
@@ -187,7 +187,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TExceptio
 
         if (MatchesPattern(exception.Message, _pattern))
         {
-            return Task.FromResult(AssertionResult.Passed);
+            return AssertionResult._passedTask;
         }
 
         return Task.FromResult(AssertionResult.Failed(
@@ -249,7 +249,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TExceptio
 
         if (_matcher.IsMatch(exception.Message))
         {
-            return Task.FromResult(AssertionResult.Passed);
+            return AssertionResult._passedTask;
         }
 
         return Task.FromResult(AssertionResult.Failed(
@@ -305,7 +305,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TExceptio
         {
             if (argumentException.ParamName == _expectedParameterName)
             {
-                return Task.FromResult(AssertionResult.Passed);
+                return AssertionResult._passedTask;
             }
 
             return Task.FromResult(AssertionResult.Failed(

TUnit.Assertions/Conditions/FileSystemAssertions.cs

@@ -42,7 +42,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<Directory
             return Task.FromResult(AssertionResult.Failed($"directory '{value.FullName}' has no files"));
         }
 
-        return Task.FromResult(AssertionResult.Passed);
+        return AssertionResult._passedTask;
     }
 
     protected override string GetExpectation() => "to have files";
@@ -84,7 +84,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<Directory
             return Task.FromResult(AssertionResult.Failed($"directory '{value.FullName}' has {subdirectories.Length} subdirectories"));
         }
 
-        return Task.FromResult(AssertionResult.Passed);
+        return AssertionResult._passedTask;
     }
 
     protected override string GetExpectation() => "to have no subdirectories";
@@ -126,7 +126,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<FileInfo>
             return Task.FromResult(AssertionResult.Failed($"file '{value.FullName}' is a system file"));
         }
 
-        return Task.FromResult(AssertionResult.Passed);
+        return AssertionResult._passedTask;
     }
 
     protected override string GetExpectation() => "to not be a system file";
@@ -170,7 +170,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<FileInfo>
             return Task.FromResult(AssertionResult.Failed($"file '{value.FullName}' is executable (extension: {value.Extension})"));
         }
 
-        return Task.FromResult(AssertionResult.Passed);
+        return AssertionResult._passedTask;
     }
 
     protected override string GetExpectation() => "to not be executable";

TUnit.Assertions/Conditions/GreaterThanAssertion.cs

@@ -34,7 +34,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TValue> m
 
         if (value.CompareTo(_minimum) > 0)
         {
-            return Task.FromResult(AssertionResult.Passed);
+            return AssertionResult._passedTask;
         }
 
         return Task.FromResult(AssertionResult.Failed($"found {value}"));
@@ -72,7 +72,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TValue> m
 
         if (value.CompareTo(_minimum) >= 0)
         {
-            return Task.FromResult(AssertionResult.Passed);
+            return AssertionResult._passedTask;
         }
 
         return Task.FromResult(AssertionResult.Failed($"found {value}"));

TUnit.Assertions/Conditions/LessThanAssertion.cs

@@ -33,7 +33,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TValue> m
 
         if (value.CompareTo(_maximum) < 0)
         {
-            return Task.FromResult(AssertionResult.Passed);
+            return AssertionResult._passedTask;
         }
 
         return Task.FromResult(AssertionResult.Failed($"found {value}"));
@@ -71,7 +71,7 @@ protected override Task<AssertionResult> CheckAsync(EvaluationMetadata<TValue> m
 
         if (value.CompareTo(_maximum) <= 0)
         {
-            return Task.FromResult(AssertionResult.Passed);
+            return AssertionResult._passedTask;
         }
 
         return Task.FromResult(AssertionResult.Failed($"found {value}"));