Skip to content

fix: CI infrastructure issues #4502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 2 commits into from
Jan 18, 2026
+8 −8
Merged

fix: CI infrastructure issues #4502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f55ea83
fix: CI infrastructure issues
thomhurst Jan 18, 2026
b2e4406
fix: remove platform restrictions from FSharp/VB nuget test modules
thomhurst Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions TUnit.Assertions.Tests/WaitsForAssertionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,15 +249,17 @@ public async Task WaitsFor_Performance_Many_Quick_Polls()
// This will take many polls before succeeding
Func<int> getValue = () => Interlocked.Increment(ref counter);

// Use a more realistic polling interval (10ms) and target count (20)
// On .NET Framework, the minimum timer resolution is ~15ms, making 1ms intervals unreliable
await Assert.That(getValue).WaitsFor(
assert => assert.IsGreaterThan(100),
assert => assert.IsGreaterThan(20),
timeout: TimeSpan.FromSeconds(5),
pollingInterval: TimeSpan.FromMilliseconds(1));
pollingInterval: TimeSpan.FromMilliseconds(10));

stopwatch.Stop();

// Should have made at least 100 attempts
await Assert.That(counter).IsGreaterThanOrEqualTo(101);
// Should have made at least 20 attempts
await Assert.That(counter).IsGreaterThanOrEqualTo(21);

// Should complete in a reasonable time (well under 5 seconds)
await Assert.That(stopwatch.Elapsed).IsLessThan(TimeSpan.FromSeconds(2));
Expand Down
2 changes: 0 additions & 2 deletions TUnit.Pipeline/Modules/TestNugetPackageModule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,11 @@ public class TestNugetPackageModule : AbstractTestNugetPackageModule
public override string ProjectName => "TUnit.NugetTester.csproj";
}

[RunOnWindowsOnly, RunOnLinuxOnly]
public class TestFSharpNugetPackageModule : AbstractTestNugetPackageModule
{
public override string ProjectName => "TUnit.NugetTester.FSharp.fsproj";
}

[RunOnWindowsOnly, RunOnLinuxOnly]
public class TestVBNugetPackageModule : AbstractTestNugetPackageModule
{
public override string ProjectName => "TUnit.NugetTester.VB.vbproj";
Expand Down
2 changes: 1 addition & 1 deletion ...t-nuget-tester/TUnit.NugetTester/TUnit.NugetTester.FSharp/TUnit.NugetTester.FSharp.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net6.0;net8.0;net9.0;net462;net472;net48;net481</TargetFrameworks>
<TargetFrameworks>net6.0;net8.0;net9.0;net10.0;net462;net472;net48;net481</TargetFrameworks>
<LangVersion>latest</LangVersion>
<IsLibraryTestProject>true</IsLibraryTestProject>
<ImplicitUsings>enable</ImplicitUsings>
Expand Down
2 changes: 1 addition & 1 deletion tools/tunit-nuget-tester/TUnit.NugetTester/TUnit.NugetTester.VB/TUnit.NugetTester.VB.vbproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net6.0;net8.0;net9.0;net462;net472;net48;net481</TargetFrameworks>
<TargetFrameworks>net6.0;net8.0;net9.0;net10.0;net462;net472;net48;net481</TargetFrameworks>
<LangVersion>latest</LangVersion>
<IsLibraryTestProject>true</IsLibraryTestProject>
<ImplicitUsings>enable</ImplicitUsings>
Expand Down
Loading