-
-
Notifications
You must be signed in to change notification settings - Fork 108
perf: eliminate Func and closure allocation in DedicatedThreadExecutor
#4455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SummaryEliminates closure and Func allocation in DedicatedThreadExecutor by passing action as a parameter to StartNew instead of capturing it. Critical IssuesNone found ✅ SuggestionsNone - this is a clean performance optimization with measurable benefit in a hot path. Verdict✅ APPROVE - No critical issues The static lambda + parameter passing approach correctly eliminates the closure allocation while maintaining the same behavior. The cast back to |
Head branch was pushed to by a user without write access
7ffe62d to
7254646
Compare
Pass
actionintoStartNeweliminating allocation ofFunc<TResult>and associated closureBefore
After