Skip to content

perf: avoid creating closure #4393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 1 commit into from
Jan 13, 2026
Merged

perf: avoid creating closure #4393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion TUnit.Core/Models/TestModels/AssemblyMetadata.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ public record AssemblyMetadata
private static readonly ConcurrentDictionary<string, AssemblyMetadata> Cache = [];
public static AssemblyMetadata GetOrAdd(string name, Func<AssemblyMetadata> factory)
{
return Cache.GetOrAdd(name, _ => factory());
return Cache.GetOrAdd(name, static (_, factory) => factory(), factory);
}

public virtual bool Equals(AssemblyMetadata? other)
Expand Down
4 changes: 2 additions & 2 deletions TUnit.Core/Models/TestModels/ClassMetadata.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ public static ClassMetadata GetOrAdd(string name, Func<ClassMetadata> factory)
}
return existing;
}

// Otherwise add new value
return Cache.GetOrAdd(name, _ => factory());
return Cache.GetOrAdd(name, static (_, factory) => factory(), factory);
}

public virtual bool Equals(ClassMetadata? other)
Expand Down
1 change: 0 additions & 1 deletion TUnit.Engine/Building/TestBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -967,7 +967,6 @@ public async Task<AbstractExecutableTest> BuildTestAsync(TestMetadata metadata,
return firstSkipAttribute?.Reason;
}


private async ValueTask<TestContext> CreateTestContextAsync(string testId, TestMetadata metadata, TestData testData, TestBuilderContext testBuilderContext)
{
// Use attributes from context if available, or create new ones
Expand Down
Loading