-
-
Notifications
You must be signed in to change notification settings - Fork 108
perf: use ConcurrentDictionary in TestRunner
#4359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
15a1741 to
52ecbe8
Compare
SummaryReplaces Critical IssuesNone found ✅ Suggestions
The change looks solid - good performance optimization! 🚀 Verdict✅ APPROVE - No critical issues, performance improvement aligns with TUnit's "Performance First" principle |
Replace
ThreadSafeDictionarywithConcurrentDictionaryinTestRunner.tcsFunc, closure orLazytypeWhy does this method return
ValueTaskit doesn't wrap a type ieValueTask<T>so we aren't benefitting from it being a struct. There are some small saving to be made by directly returning theTask. This is because in a state machineTaskis an 8 bytes pointer whereasValueTaskis a 16 bytestruct. Massive nit pick but it does add upBefore
After