Skip to content

perf: TestExtensions eliminate closure with equality #4350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 1 commit into from
Jan 13, 2026
Merged

perf: TestExtensions eliminate closure with equality #4350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions TUnit.Engine/Extensions/TestExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,12 @@ private static string GetCachedAssemblyFullName(Assembly assembly)

private static CachedTestNodeProperties GetOrCreateCachedProperties(TestContext testContext)
{
var testDetails = testContext.Metadata.TestDetails;
var testId = testDetails.TestId;
var testId = testContext.Metadata.TestDetails.TestId;

return TestNodePropertiesCache.GetOrAdd(testId, _ =>
return TestNodePropertiesCache.GetOrAdd(testId, static (_, testContext) =>
{
var testDetails = testContext.Metadata.TestDetails;

var fileLocation = new TestFileLocationProperty(testDetails.TestFilePath, new LinePositionSpan(
new LinePosition(testDetails.TestLineNumber, 0),
new LinePosition(testDetails.TestLineNumber, 0)
Expand Down Expand Up @@ -108,7 +109,7 @@ private static CachedTestNodeProperties GetOrCreateCachedProperties(TestContext
TrxFullyQualifiedTypeName = trxTypeName,
TrxCategories = trxCategories
};
});
}, testContext);
}

internal static TestNode ToTestNode(this TestContext testContext, TestNodeStateProperty stateProperty)
Expand Down
Loading