perf: prevent Func allocation with method group
#4242
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimothyMakkison
force-pushed
the
prop_cache
branch
from
8a008cf to
c411a43
Compare
TimothyMakkison
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
TimothyMakkison
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
TimothyMakkison
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
This was referenced Jan 6, 2026
This was referenced Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses method group to avoid allocating a new
Funcand closure wheneverGetOrCreatePlanis called.I'm assuming
PropertyInjectionPlanBuilder.Buildis extremely expensive to run hence this code? Was the thread safe caching added for safety reasons or just performance?Before
After