fix: use inline DisplayName, Skip, and Categories properties on [Arguments] attribute in NUnit migration

[thomhurst]

Summary

• Updates NUnit migration code fixers to use the new inline properties on [Arguments] attribute (added in feat: add DisplayName, Skip, and Categories support for parameterized tests #4214)
• Maps NUnit TestCase properties to TUnit inline properties instead of generating separate attributes:
  • TestName → DisplayName (inline on [Arguments])
  • Category → Categories array (inline on [Arguments])
  • Ignore/IgnoreReason → Skip (inline on [Arguments])
• Properties that don't have TUnit inline equivalents still generate separate attributes:
  • Description → [Property("Description", "...")]
  • Author → [Property("Author", "...")]
  • Explicit → [Explicit]

Example Migration

Before (NUnit):

[TestCase(1, TestName = "Test One", Category = "Unit", Ignore = "WIP")]
[TestCase(2, TestName = "Test Two", Category = "Integration")]
public void MyTest(int value) { }

After (TUnit):

[Test]
[Arguments(1, DisplayName = "Test One", Skip = "WIP", Categories = ["Unit"])]
[Arguments(2, DisplayName = "Test Two", Categories = ["Integration"])]
public void MyTest(int value) { }

Test plan

• All 44 NUnit migration analyzer tests pass
• Added tests for Ignore → Skip inline conversion
• Added tests for IgnoreReason → Skip inline conversion
• Added comprehensive test with all inline properties (DisplayName, Skip, Categories)
• Added test with all properties (inline + separate attributes)

🤖 Generated with Claude Code

[thomhurst]

Summary

This PR enhances the NUnit migration code fixer to handle TestName, Category, and Ignore properties inline on the [Arguments] attribute instead of generating separate attributes.

Critical Issues

None found ✅

Suggestions

Consider argument ordering edge case

In NUnitExpectedResultRewriter.cs:442-525, the code ensures proper ordering: positional args → ExpectedResult → named properties. However, in NUnitMigrationCodeFixProvider.cs:84-136, there's no similar separation of positional vs named arguments before adding the Categories array at the end.

While this likely works in practice (since Categories is added last and C# allows named arguments after positional ones), for consistency with the NUnitExpectedResultRewriter approach, consider explicitly separating positional and named arguments in ConvertTestCaseArguments as well.

Test coverage is excellent

The new test cases comprehensively cover:

• Individual properties (TestName, Category, Ignore, IgnoreReason)
• Multiple properties combined
• Comprehensive scenario with all properties

This demonstrates good testing discipline.

Verdict

✅ APPROVE - No critical issues. The implementation correctly handles inline property conversion with comprehensive test coverage. The suggestion is a minor consistency improvement, not a blocking issue.

[Copilot]

Pull request overview

This pull request enhances the NUnit to TUnit migration code fixers by utilizing the new inline properties on the [Arguments] attribute (added in #4214). Instead of generating separate attributes for DisplayName, Category, and Skip, these are now specified as inline named properties on each [Arguments] attribute, resulting in cleaner and more concise migrated code.

Key Changes:

• TestCase property TestName is now converted to inline DisplayName property on [Arguments]
• TestCase property Category is now converted to inline Categories array property on [Arguments]
• TestCase properties Ignore and IgnoreReason are now converted to inline Skip property on [Arguments]

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
TUnit.Analyzers.Tests/NUnitMigrationAnalyzerTests.cs	Updated existing tests to reflect inline property conversion and added comprehensive new tests for Ignore→Skip, IgnoreReason→Skip, and all inline properties combined
TUnit.Analyzers.CodeFixers/NUnitTestCasePropertyRewriter.cs	Removed extraction and generation logic for TestName/Category properties, updated documentation to clarify these are now handled inline
TUnit.Analyzers.CodeFixers/NUnitMigrationCodeFixProvider.cs	Implemented inline conversion of TestName→DisplayName, Category→Categories array, and Ignore/IgnoreReason→Skip within the Arguments attribute
TUnit.Analyzers.CodeFixers/NUnitExpectedResultRewriter.cs	Implemented the same inline property conversions for TestCase attributes with ExpectedResult, maintaining proper argument ordering (positional → ExpectedResult → named properties)