-
-
Notifications
You must be signed in to change notification settings - Fork 108
redundant allocations #4185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redundant allocations #4185
Conversation
…ing in data collectors
SummaryThis PR reduces redundant allocations in hot paths by caching parameter type arrays, attribute lookups, and assembly lists. Critical IssuesNone found ✅ Suggestions1. IsTrxEnabled static caching may be too aggressive (TestExtensions.cs:177-195)The new
Recommendation: Consider making this cache per- 2. Consider defensive null check in GetParameterTypes (MethodDataSourceAttribute.cs:269-281)The new Optional: Add a null check or document the invariant that 3. Field keyword usage for Assemblies property (ReflectionTestDataCollector.cs:36)The Just verify that:
Performance Impact AssessmentAll changes align with TUnit Rule 4: Performance First. The optimizations target hot paths: These are solid micro-optimizations. Great work! Verdict✅ APPROVE - No critical issues. Suggestions are optional improvements for consideration. |
No description provided.