-
-
Notifications
You must be signed in to change notification settings - Fork 109
fix: move permissions to workflow level for OIDC token access #4173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the `permissions:` block from the job level to the workflow level to ensure the OIDC token is available for the claude-code-action. Job-level permissions may not properly propagate the ACTIONS_ID_TOKEN_REQUEST_URL environment variable needed for id-token: write to function correctly. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
6d13815 to
d76ab27
Compare
The workflow uses `gh pr comment` which requires write access to pull requests, not just read access. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
This was referenced Dec 29, 2025
This was referenced Dec 29, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
permissions:block from job level to workflow level in claude-code-review.ymlpull-requests: readtopull-requests: writeto allow commenting on PRsProblem
ACTIONS_ID_TOKEN_REQUEST_URLenvironment variable. Job-level permissions don't always properly propagate this for actions that require OIDC tokens.gh pr commentwhich requires write access to pull requests.Solution
on:and abovejobs:)pull-requests: writeinstead ofreadto enable commenting🤖 Generated with Claude Code